[Weiye] iP by TeddYE · Pull Request #295 · nus-cs2103-AY2122S2/ip

TeddYE · 2022-01-29T07:44:51Z

No description provided.

Let's implement a skeletal version of Duke that starts by greeting the user, simply echoes commands entered by the user, and exits when the user types bye.

Let's add the ability to store whatever text entered by the user and display them back to the user when requested.

Let's, * move the conditional break in the infinite loop into the loop condition * remove String.format()

Lets, * add Task class to represent tasks * add the ability to mark tasks as done and the ability to change the status back to not done

As there are multiple types of tasks that have some similarity between them, implement classes Todo, Deadline and Event classes to inherit from a Task class. Let's, * add support for tracking three types of task

Use the input/output redirection technique to semi-automate the testing of Duke.

Teach Duke to deal with errors such as incorrect inputs entered by the user. Let's * add DukeException class

Let's * Add support for deleting tasks from the list

Let's: * use enum for types of tasks

Let's: * add abstract class for different commands

Let's: * add Storage class to facilitate reading and writing of list to file

Branch level 7

Teach duke to understand date and time. Let's * update due date and event time to LocalDateTime instead of String

Implement level-8 functionalities

Let's: * add TaskList class * add Ui class

A-MoreOOP

Add JavaDoc comments to the code

# Conflicts: # src/main/META-INF/MANIFEST.MF

Let's: * add CFind class to handle the search function * add appropriate response after the search is done

Implement Level-9 functionalities

hieunm1821

Overall, I found your code easy to read. However, there are a few minor coding standard. Just a few nits to fix.

hieunm1821 · 2022-02-03T06:16:25Z

+        this.parser = new Parser();
+    }
+
+    public void run() throws DukeException{


I think it should be a white space before the open curly bracket. I noticed the same issue in several other places too.

hieunm1821 · 2022-02-03T06:18:18Z

+import java.util.ArrayList;
+
+public class TaskList {
+    private ArrayList<Task> Tasks;


I think the variable name should be in camelCase. I suggest it should be tasks

hieunm1821 · 2022-02-03T06:22:10Z

+import main.duke.Ui;
+import main.duke.enums.CommandType;
+
+public class CBye extends Command{


Should the name of class be CommandBye? I think it is more meaningful. Similar with other command names.

hieunm1821 · 2022-02-03T06:25:22Z

+        this.findString = findString;
+    }
+
+    public String getFindString() { return this.findString; }


I suggest follow EgyptianStyle when we make a function which has one line only. I noticed the same issue in several other places too.

hieunm1821 · 2022-02-03T06:28:49Z

+        switch (userCommand) {
+            case "bye":
+                newCommand = new CBye();
+                break;
+            case "list":
+                newCommand = new CList();
+                break;
+            case "mark":
+                try {
+                    int markIndex = Integer.parseInt(inputArray[1]) - 1;
+                    newCommand = new CMark(markIndex);
+                } catch (IndexOutOfBoundsException e) {
+                    throw new DukeException("Please specify the task you wish to mark.");
+                } catch (NumberFormatException e) {
+                    throw new DukeException("Invalid index format.");
+                }
+                break;
+            case "unmark":
+                try {
+                    int unmarkIndex = Integer.parseInt(inputArray[1]) - 1;
+                    newCommand = new CUnmark(unmarkIndex);
+                } catch (IndexOutOfBoundsException e) {
+                    throw new DukeException("Please specify the task you wish to unmark.");
+                } catch (NumberFormatException e) {
+                    throw new DukeException("Invalid index format.");
+                }
+                break;
+            case "delete":
+                try {
+                    int deleteIndex = Integer.parseInt(inputArray[1]) - 1;
+                    newCommand = new CDelete(deleteIndex);
+                } catch (IndexOutOfBoundsException e) {
+                    throw new DukeException("Please specify the task you wish to delete.");
+                } catch (NumberFormatException e) {
+                    throw new DukeException("Invalid index format.");
+                }
+                break;
+            case "todo":
+                String todoDescription = String.join(" ",
+                        Arrays.copyOfRange(inputArray, 1, inputArray.length));
+                if (todoDescription.equals("")) {
+                    throw new DukeException("Please specify the description of the todo task.");
+                }
+                newCommand = new CTodo(todoDescription);
+                break;
+            case "deadline":
+                if (!userInput.contains("/by")) {
+                    throw new DukeException("Please specify the due date using the /by keyword.");
+                } else {
+                    try {
+                        int byIndex = Arrays.asList(inputArray).indexOf("/by");
+                        String deadlineDescription = String.join(" ",
+                                Arrays.copyOfRange(inputArray, 1, byIndex));
+                        String dueDate = String.join(" ",
+                                Arrays.copyOfRange(inputArray, byIndex + 1, inputArray.length));
+                        LocalDateTime.parse(dueDate, DateTimeFormatter.ofPattern("yyyy-MM-dd kkmm"));
+                        // check if the date and time input is in the right format
+                        if (deadlineDescription.equals("") || dueDate.equals("")) {
+                            throw new DukeException("Please specify the description/due date of the deadline task.");
+                        }
+                        newCommand = new CDeadline(deadlineDescription, dueDate);
+                    } catch (DateTimeParseException e){
+                        throw new DukeException("Please provide the date time in this format YYYY-MM-DD 0000");
+                    }
+                }
+                break;
+            case "event":
+                if (!userInput.contains("/at")) {
+                    throw new DukeException("Please specify the date time using the /at keyword.");
+                } else {
+                    try {
+                        int byIndex = Arrays.asList(inputArray).indexOf("/at");
+                        String eventDescription = String.join(" ",
+                                Arrays.copyOfRange(inputArray, 1, byIndex));
+                        String dateTime = String.join(" ",
+                                Arrays.copyOfRange(inputArray, byIndex + 1, inputArray.length));
+                        LocalDateTime.parse(dateTime, DateTimeFormatter.ofPattern("yyyy-MM-dd kkmm"));
+                        // check if the date and time input is in the right format
+                        if (eventDescription.equals("") || dateTime.equals("")) {
+                            throw new DukeException("Please specify the description/date time of the event task.");
+                        }
+                        newCommand = new CEvent(eventDescription, dateTime);
+                    } catch (DateTimeParseException e){
+                        throw new DukeException("Please provide the date time in this format YYYY-MM-DD 0000");
+                    }
+                }
+                break;
+            case "find":
+                String findString = String.join(" ",
+                        Arrays.copyOfRange(inputArray, 1, inputArray.length));
+                newCommand = new CFind(findString);
+                break;
+            default:
+                throw new DukeException("Sorry. I do not understand your input.");
+        }
+        return newCommand;


I think there is no indentation for case clauses. I suggest you change the setting in the IDE.

hieunm1821 · 2022-02-03T06:30:27Z

+
+import main.duke.enums.TaskType;
+
+public class ToDo extends Task{


Should the class name Todo? 🤔

Use Gradle to automate some of the build tasks of the project

kahleongq

Overall you adhered mostly to the coding standards!

kahleongq · 2022-02-06T08:53:33Z

+        String userCommand = inputArray[0];
+        Command newCommand;
+
+        switch (userCommand) {


there should not be an indentation for case clauses to follow the coding standards

Add GUI supoport

Implement Level-10 functionalities

Improve code quality based on Code Quality topics

Use Assertions

Added cloning function for the tasks so that the previous state of the tasks list can be saved. Stack is used to store the previous state of the tasks list. Unifying all those duplicated code improves the code quality. As a step towards such unification, let's extract those duplicated code blocks into separate methods in their respective classes. Doing so will make the subsequent unification easier.

Add user guide

TeddYE added 9 commits January 23, 2022 17:30

Duke class: implement level 1 functionalities

356f7d2

Let's implement a skeletal version of Duke that starts by greeting the user, simply echoes commands entered by the user, and exits when the user types bye.

Duke class: Implement level 2 functionalities

5741e28

Let's add the ability to store whatever text entered by the user and display them back to the user when requested.

Duke class: remove redundant codes

ad6aed9

Let's, * move the conditional break in the infinite loop into the loop condition * remove String.format()

Duke class: Implement Level-3 functionalities

44b496e

Lets, * add Task class to represent tasks * add the ability to mark tasks as done and the ability to change the status back to not done

Duke class: implement Level-4 functionalities

ae02dd3

As there are multiple types of tasks that have some similarity between them, implement classes Todo, Deadline and Event classes to inherit from a Task class. Let's, * add support for tracking three types of task

Update i/o files for testing

bee688a

Use the input/output redirection technique to semi-automate the testing of Duke.

Duke class: implement level-5 functionalities

6fe8ceb

Teach Duke to deal with errors such as incorrect inputs entered by the user. Let's * add DukeException class

Duke class: implement level-6 functionalities

3910a1f

Let's * Add support for deleting tasks from the list

Implement A-Enums functionalities

8874be8

Let's: * use enum for types of tasks

TeddYE changed the title ~~[Weiye] ip~~ [Weiye] iP Jan 29, 2022

TeddYE and others added 16 commits January 30, 2022 22:51

Add parser class to parse the user input into different commands

042bfe3

Let's: * add abstract class for different commands

Duke class: implement level-7 functionalities

256377e

Let's: * add Storage class to facilitate reading and writing of list to file

Merge pull request #1 from TeddYE/branch-Level-7

7e35173

Branch level 7

Implement level-8 functionalities

0762e16

Teach duke to understand date and time. Let's * update due date and event time to LocalDateTime instead of String

Merge pull request #2 from TeddYE/branch-Level-8

9fe0dc0

Implement level-8 functionalities

Refactor the code to extract out closely related code as classes

325bed9

Let's: * add TaskList class * add Ui class

Merge pull request #3 from TeddYE/branch-Level-8

ebfabea

A-MoreOOP

Organize the classes into suitable java packages

c0f4f9e

Add JUnit tests to test the behavior of the code

96e5e0a

Package the app as an executable JAR file

3aad3db

Add JavaDoc comments to the code

53c09c9

Reorganize the directories

3b36a90

Merge pull request #4 from TeddYE/branch-A-JavaDoc

76d9ffa

Add JavaDoc comments to the code

Merge branch 'master' of https://github.com/TeddYE/ip

b4ab6bc

# Conflicts: # src/main/META-INF/MANIFEST.MF

Implement Level-9 functionalities

4c48792

Let's: * add CFind class to handle the search function * add appropriate response after the search is done

Merge pull request #6 from TeddYE/branch-Level-9

f4e7989

Implement Level-9 functionalities

hieunm1821 reviewed Feb 3, 2022

View reviewed changes

TeddYE and others added 2 commits February 5, 2022 23:14

Use Gradle to automate some of the build tasks of the project

fb5007d

Merge pull request #7 from TeddYE/add-gradle-support

91075bd

Use Gradle to automate some of the build tasks of the project

kahleongq reviewed Feb 6, 2022

View reviewed changes

TeddYE and others added 17 commits February 9, 2022 15:35

Implement Level-10 functionalities

746eb08

Add GUI supoport

Merge pull request #8 from TeddYE/branch-Level-10

7cae665

Implement Level-10 functionalities

Improve code quality based on Code Quality topics

eecd61c

Merge pull request #9 from TeddYE/branch-A-CodeQuality

d1ed7b3

Improve code quality based on Code Quality topics

Use Assertions

8ad414d

Merge pull request #10 from TeddYE/branch-A-Assertions

28b855f

Use Assertions

Add user guide

1bd155d

Merge pull request #12 from TeddYE/branch-UserGuide

108359b

Add user guide

Set theme jekyll-theme-minimal

c488e8e

Set theme jekyll-theme-dinky

ce71260

Update comments in accordance to coding standards

4aad472

Add ui picture

13a66ce

Set theme jekyll-theme-dinky

67f7f67

Change ui picture file name

befb8c4

Merge branch 'master' of https://github.com/TeddYE/ip

61216bf

Update main class name in build.gradle

13f4072

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Weiye] iP#295

[Weiye] iP#295
TeddYE wants to merge 44 commits into
nus-cs2103-AY2122S2:masterfrom
TeddYE:master

TeddYE commented Jan 29, 2022

Uh oh!

hieunm1821 left a comment

Uh oh!

hieunm1821 Feb 3, 2022

Uh oh!

hieunm1821 Feb 3, 2022

Uh oh!

hieunm1821 Feb 3, 2022

Uh oh!

hieunm1821 Feb 3, 2022

Uh oh!

hieunm1821 Feb 3, 2022

Uh oh!

hieunm1821 Feb 3, 2022

Uh oh!

kahleongq left a comment

Uh oh!

kahleongq Feb 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		import main.duke.enums.TaskType;

		public class ToDo extends Task{

Conversation

TeddYE commented Jan 29, 2022

Uh oh!

hieunm1821 left a comment

Choose a reason for hiding this comment

Uh oh!

hieunm1821 Feb 3, 2022

Choose a reason for hiding this comment

Uh oh!

hieunm1821 Feb 3, 2022

Choose a reason for hiding this comment

Uh oh!

hieunm1821 Feb 3, 2022

Choose a reason for hiding this comment

Uh oh!

hieunm1821 Feb 3, 2022

Choose a reason for hiding this comment

Uh oh!

hieunm1821 Feb 3, 2022

Choose a reason for hiding this comment

Uh oh!

hieunm1821 Feb 3, 2022

Choose a reason for hiding this comment

Uh oh!

kahleongq left a comment

Choose a reason for hiding this comment

Uh oh!

kahleongq Feb 6, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants