[Gernene Tan] iP

[Gernene]

Duke

Create

• Deadlines

• Events

• Todo Items

• Check off items

• Mark tasks as not done

1. Fast
2. Simple
3. Easy

I am Duke!

public void start(Stage stage) {
        try {
            FXMLLoader fxmlLoader = new FXMLLoader(Main.class.getResource("/view/MainWindow.fxml"));
            AnchorPane ap = fxmlLoader.load();
            Scene scene = new Scene(ap);
            scene.getStylesheets().add(Main.class.getResource("/css/style.css").toExternalForm());
            String home = System.getProperty("user.home");
            Path directory = Paths.get(home, "Documents", "duke");
            Path filePath = Paths.get(home, "Documents", "duke", "data.txt");
            duke = new Duke(directory, filePath);
            stage.setScene(scene);
            fxmlLoader.<MainWindow>getController().setDuke(duke);
            stage.show();
        } catch (IOException e) {
            e.printStackTrace();
        }
    }

list

😄

Download here

[kerburenthusiasm]

Overall, I found your code easy to read and they follow the Java coding standard provided. However, some files such as Parser.java were difficult to read due to the nested if-else statements. Consider encapsulating some similar statements into a function to improve readability.

[kerburenthusiasm]

Perhaps a change to the function name to sound more like a boolean?

Suggested change

	public boolean contains(String str) {
	public boolean hasString(String str) {

[kerburenthusiasm]

Perhaps a change to the argument name to sound more like a boolean? I noticed this issue occurring in classes extending task.

Suggested change

	public Todo(String description, boolean status) {
	public Todo(String description, boolean isMarked) {

[kerburenthusiasm]

Perhaps add header comments for the class and public functions. I noticed the same issue for classes extending Task and Command?

[EvaderFati]

Overall your code closely follows the coding standard and is nicely constructed. Only some small writing problems to fix.

[EvaderFati]

Although it is not required, it is recommended to add the '@ Override' annotation. https://stackoverflow.com/questions/1005898/should-i-add-an-override-annotation-when-implementing-abstract-methods-in-java

[EvaderFati]

According to the stupid Coding standard, should it be better to indent this line as 4 spaces instead of 2?

[markbiju]

Excellent attempt at following coding standard with absolutely minimal coding standard violations

[markbiju]

Perhaps you could name status to be more boolean-sounding? :)

[markbiju]

Commendable discretion shown here to differentiate when to use camelCase and when to use PascalCase.

[markbiju]

The if-else class of statements should have the following form:
if (condition) {
statements;
} else if (condition) {
statements;
} else {
statements;
}

[markbiju]

Perhaps this line is rather long and would benefit from a line break?