[KristopherPTaslim] iP by KristopherPTaslim · Pull Request #287 · nus-cs2103-AY2122S2/ip

KristopherPTaslim · 2022-01-28T09:55:25Z

DukePro

"Your mind is for having ideas, not holding them." - David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here
double-click it.
add your tasks
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon

If you java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

pnutzz-0207

Overall you are following the coding standards, very good job! 💯 just a few minor mistakes made, after you change it, it'll all look good to me 👏

pnutzz-0207 · 2022-02-03T07:09:13Z

+import java.util.ArrayList;
+import java.util.Scanner;
+import java.io.IOException;
+import java.time.LocalDateTime;
+import java.time.format.DateTimeFormatter;


Following the coding standards, you might need to arrange the import statements into alphabetical order! :)
Same for some of the other classes that includes import statements.

Suggested change

import java.util.ArrayList;

import java.util.Scanner;

import java.io.IOException;

import java.time.LocalDateTime;

import java.time.format.DateTimeFormatter;

import java.io.IOException;

import java.time.format.DateTimeFormatter;

import java.time.LocalDateTime;

import java.util.ArrayList;

import java.util.Scanner;

pnutzz-0207 · 2022-02-03T07:10:51Z

+
+class Duke {
+
+    public static void main(String[] args) throws DukeException{


You might need to leave a space after DukeException

Suggested change

public static void main(String[] args) throws DukeException{

public static void main(String[] args) throws DukeException {

pnutzz-0207 · 2022-02-03T07:11:47Z

+        FileClass fc = new FileClass(); //file class 
+        String home = System.getProperty("user.home"); //home directory


I like how you make comments behind the lines! It makes the logic clear 😄

pnutzz-0207 · 2022-02-03T07:15:02Z

+                        String dateTime = input.substring(indexOfTime + deadlineCondition.length(), input.length()); // the date and time for by
+                        //convert to the correct one
+                        LocalDateTime deadlineTime = LocalDateTime.parse(dateTime, DateTimeFormatter.ofPattern("d/M/y Hmm"));
+                        String convertedTime = deadlineTime.format(DateTimeFormatter.ofPattern("MMM d yyyy hh:mm a"));


I like how you name your variables :), it is very clear what they all do 👍

pnutzz-0207 · 2022-02-03T07:16:40Z

+
+        // Recording everything in the duke.txt
+        for (int i = 0; i < taskArray.size(); i++ ) {
+            Task tasks = taskArray.get(i);


Since it is referring to just 1 task, will it be better to name this variable as 'task' instead of 'tasks'?

manu2002g

Great code quality! The variable names used are all short and descriptive and help a lot to make the code easy to understand! 😄

manu2002g · 2022-02-05T18:17:49Z

+                        int indexOfTime = input.indexOf(eventCondition); //to find /
+                        String dateTime = input.substring(indexOfTime + eventCondition.length(), input.length()); // the date and time for by
+                        //convert to the correct one
+                        LocalDateTime eventTime = LocalDateTime.parse(dateTime, DateTimeFormatter.ofPattern("d/M/y Hmm"));
+                        String convertedTime = eventTime.format(DateTimeFormatter.ofPattern("MMM d yyyy hh:mm a"));
+                        String stringSliced = input.substring(6, indexOfTime); // after deadline
+                        stringArray.add(stringSliced);
+                        Event eventTask = new Event(stringSliced, convertedTime);
+                        taskArray.add(eventTask);
+                        String noOfTask = String.valueOf(taskArray.size());
+                        System.out.println(messageTask + eventTask.toString() + "\n"


Great use of comments to clarify what each line is doing! Maybe you could also use a few blank lines to separate the code block into logical sections (such as formatting, processing and output.) The coding standard recommends that "Logical units within a block should be separated by one blank line."

manu2002g · 2022-02-05T18:26:41Z

+                            System.out.println(index + "." + taskArray.get(i));
+                        }
+                    }
+                } else if (checkType[0].equals("mark") || checkType[0].equals("unmark")) { //this is to check whether it goes through marking


I think this line has more than the 120 character line limit allowed by the coding standard. Maybe you could add a line break to improve readability

manu2002g · 2022-02-05T18:27:25Z

+
+                    try {
+                        int index = Integer.parseInt(checkType[1]) - 1;
+                        Task tasks = taskArray.get(index);


Maybe change the name of this variable to task since it only refers to a single entry

kahleongq

Overall you adhered mostly to the coding standards, keep it up!

kahleongq · 2022-02-06T08:34:47Z

+            default:
+                ui.showDefaultMessage();
+                break;
+


Perhaps you could remove the indentation for the case clauses to follow the coding standards

ghost

Hi Kris! Code is generally well done, just keep in mind that it's best to break up code into smaller blocks for increased readability and to use more descriptive naming:)

ghost · 2022-02-06T12:36:47Z

+    public Deadline(String description, String by) {
+        super(description);
+        this.by = by;
+    }


Perhaps you could rename "by" to something more descriptive.

Suggested change

public Deadline(String description, String by) {

super(description);

this.by = by;

}

public Deadline(String description, String deadlineDate) {

super(description);

this.deadlineDate = deadlineDate;

}

ghost · 2022-02-06T12:38:01Z

+            Parser parser = new Parser(taskList);
+
+            while (sc.hasNextLine()) {
+                parser.execute(input);


perhaps you can change the name of the method since a parser is parsing an input

Suggested change

parser.execute(input);

parser.parseInput(input);

ghost · 2022-02-06T12:38:58Z

+    public DukeException(String Message) {
+        super(Message);
+    }


You could add a more descriptive message to be stored within the DukeException class

ghost · 2022-02-06T12:40:03Z

+    public Event(String description, String at) {
+        super(description);
+        this.at = at;
+    }


Same thing with the deadline task

Suggested change

public Event(String description, String at) {

super(description);

this.at = at;

}

public Event(String description, String eventDate) {

super(description);

this.eventDate= eventDate;

}

ghost · 2022-02-06T12:43:03Z

+        switch (checkCase[0].toLowerCase()) {
+
+            case ("list"): 
+                ui.showListMessage(taskList);
+                break;
+
+            case ("mark"):
+                try {
+                    int index = Integer.parseInt(checkCase[1]) - 1;
+                    Task tasks = taskList.getTaskArray().get(index);
+                    System.out.println(tasks.marking(checkCase[0].toLowerCase()));
+                    taskList.getTaskArray().set(index, tasks);
+                } catch (ArrayIndexOutOfBoundsException e) {
+                    ui.showInvalidInput();
+                }
+                break;
+
+            case ("unmark"):
+                try {
+                    int index = Integer.parseInt(checkCase[1]) - 1;
+                    Task tasks = taskList.getTaskArray().get(index);
+                    System.out.println(tasks.marking(checkCase[0].toLowerCase()));
+                    taskList.getTaskArray().set(index, tasks);
+                } catch (ArrayIndexOutOfBoundsException e) {
+                    ui.showInvalidInput();
+                }
+                break;
+
+            case ("todo"):
+
+                try {
+                    String toDoCondition = "todo ";
+                    int indexOfToDo = toDoCondition.length(); //to find todo
+                    String stringSliced = input.substring(indexOfToDo,input.length());
+                    Todo todoTask = new Todo(stringSliced);
+                    taskList.addTask(todoTask);
+                    String noOfTask = String.valueOf(taskList.getTaskArray().size());
+                    ui.showAddedMessage(todoTask, noOfTask);
+                } catch (StringIndexOutOfBoundsException e) {
+                    ui.showTodoError();
+                }
+                break;
+
+            case ("deadline"):
+
+                try {
+                    String deadlineCondition = "/by ";
+                    int indexOfTime = input.indexOf(deadlineCondition); //to find /
+                    String dateTime = input.substring(indexOfTime + deadlineCondition.length(), input.length()); // the date and time for by
+                    //convert to the correct one
+                    LocalDateTime deadlineTime = LocalDateTime.parse(dateTime, DateTimeFormatter.ofPattern("d/M/y Hmm"));
+                    String convertedTime = deadlineTime.format(DateTimeFormatter.ofPattern("MMM d yyyy hh:mm a"));
+                    String stringSliced = input.substring(9, indexOfTime); // after deadline
+                    Deadline deadlineTask = new Deadline(stringSliced, convertedTime);
+                    taskList.addTask(deadlineTask);
+                    String noOfTask = String.valueOf(taskList.getTaskArray().size());
+                    ui.showAddedMessage(deadlineTask, noOfTask);
+                } catch (StringIndexOutOfBoundsException e) {
+                    ui.showDeadlineError();
+                }
+                break;
+
+            case ("event"):
+
+                try {
+                    String eventCondition = "/at ";
+                    int indexOfTime = input.indexOf(eventCondition); //to find /
+                    String dateTime = input.substring(indexOfTime + eventCondition.length(), input.length()); // the date and time for at
+                    //convert to the correct one
+                    LocalDateTime eventTime = LocalDateTime.parse(dateTime, DateTimeFormatter.ofPattern("d/M/y Hmm"));
+                    String convertedTime = eventTime.format(DateTimeFormatter.ofPattern("MMM d yyyy hh:mm a"));
+                    String stringSliced = input.substring(6, indexOfTime); // after deadline
+                    Event eventTask = new Event(stringSliced, convertedTime);
+                    taskList.addTask(eventTask);
+                    String noOfTask = String.valueOf(taskList.getTaskArray().size());
+                    ui.showAddedMessage(eventTask, noOfTask);
+
+                } catch (StringIndexOutOfBoundsException e) {
+                    ui.showEventError();
+                }
+                break;
+
+            case("delete"):
+
+                try {
+                    int index = Integer.parseInt(checkCase[1]) - 1;
+                    Task task = taskList.getTaskArray().get(index);
+                    taskList.deleteTask(index);
+                    String noOfTask = String.valueOf(taskList.getTaskArray().size());
+                    ui.showDeletedMessage(task, noOfTask);
+                } catch (ArrayIndexOutOfBoundsException e) {
+                    ui.showDeleteError();
+                }
+                break;
+
+            case("bye"):
+                ui.showGoodbyeMessage();
+                break;             
+
+            default:
+                ui.showDefaultMessage();
+                break;
+
+
+
+        }
+
+
+    }


Apart from the coding standard violations, perhaps you can break up each case instruction into separate methods for increased readability?

For example:

public void delete() { try { int index = Integer.parseInt(checkCase[1]) - 1; Task task = taskList.getTaskArray().get(index); taskList.deleteTask(index); String noOfTask = String.valueOf(taskList.getTaskArray().size()); ui.showDeletedMessage(task, noOfTask); } catch (ArrayIndexOutOfBoundsException e) { ui.showDeleteError(); } }

…-Gradle

The method execute() does not follow the coding standard due to its length. There are common logic in the method which cause code duplication. Extracting this common logic allows the method to be significantly shorter and the principle of SLAP to be followed. For example, the method parseByCondition() and parseString() shows the SLAP principle.

Assertions are required in order to check whether the code is able to work. Assertions allow assertion error to be thrown if some conditions are not held properly. For example, implementing assertion task cannot be null in the method showAddedMessage(Task task, String noOfTask) will throw assertion error if the input of task is null.

Add assertions in some various points in code

Edit execute() method in Parser class to follow coding standard.

damithc and others added 12 commits July 29, 2021 20:30

Add Gradle support

d839859

Level-1

5406049

Finish Level-2

0dd972e

Finish Level-3

1812262

Finish Level-4

277c43f

Finish Level-5

73b1d1c

Finish Level-6

d619a83

Finish Testing

318b3aa

Finish Branch-Level-7

32bb23a

Finish branch-Level-8

bc9608c

Merge branch 'branch-Level-8'

e754bcb

Debug Branch Level-7

b37f27b

pnutzz-0207 reviewed Feb 3, 2022

View reviewed changes

manu2002g reviewed Feb 5, 2022

View reviewed changes

Finish A-MOREOOP

83bb0f3

kahleongq reviewed Feb 6, 2022

View reviewed changes

Finish A-Packages

27fc406

ghost reviewed Feb 6, 2022

View reviewed changes

KristopherPTaslim added 12 commits February 7, 2022 22:03

Finish A-JUnit

589b161

Debug A-JUnit

e8b6b2a

Delete the wrong folder test:java:duke

28a85db

Finish A-Javadoc

7bbe7be

Added missing JavaDoc in the branch-A-JavaDoc

7b43639

Finish A-CodingStandard

bbc3057

Finish branch-Level-9

6ea1b8c

Merge tag 'branch-A-CodingStandard'

3d551ba

Merge tag 'branch-Level-9'

452a916

Merging all the three branches(JavaDoc, Coding Standard and Level 9)

aa60d80

Merge commit 'd8398594b7bc43da5eb865321c5a50cec4b3923d' into branch-A…

6b75a3c

…-Gradle

Finish running branch-A-Gradle

725a458

KristopherPTaslim and others added 13 commits February 14, 2022 16:46

Finish Level-10

fd68d86

Fix Minor Bug

80a985b

Merge pull request #2 from KristopherPTaslim/branch-A-Assertions

c3d28a2

Add assertions in some various points in code

Merge branch 'master' into branch-A-CodeQuality

97d12b1

Merge pull request #3 from KristopherPTaslim/branch-A-CodeQuality

1dfa71f

Edit execute() method in Parser class to follow coding standard.

Edit minor feature in Parser class

c96d62b

Finish branch-BCD-Extension

36ccfcc

Add Ui.png under the docs folder

99300b0

Update ReadME.md

7e5a187

Update ReadME.md

cc38eb8

Edit some parts in build.gradle

1a329c8


		class Duke {

		public static void main(String[] args) throws DukeException{

		FileClass fc = new FileClass(); //file class
		String home = System.getProperty("user.home"); //home directory

Conversation

KristopherPTaslim commented Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DukePro

Uh oh!

pnutzz-0207 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manu2002g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kahleongq left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KristopherPTaslim commented Jan 28, 2022 •

edited

Loading