[Lim Yu Long] ip #634
Open
yulonglim wants to merge 51 commits into
Open
Conversation
Branch level 7
Add Gradle support
Branch level 10
Updated readme
Update README.md
User may not remember the letter casing of the task description Made find not case sensitive To improve user experience using the application
Current find is case sensitive
Had many essential methods not have javadocs Placed taskparse function in Parser.java and add javadocs for some methods Improved code quality
A-CodeQuality
User may have made small errors when adding task and needs to delete and add This is not user friendly and waste a lot of time Hence new gui allows for updating of task easily
User may have made small errors when adding task and needs to delete and add This is not user friendly and waste a lot of time Hence new gui allows for updating of task easily
Screenshot for user guide was not present Added Ui.png Let users see a preview of the ui before they use it
Users previously may input wrong items for add task Now gui will inform the specific problem Duke.txt moved to resource folder
Previous code was done at java 15 Updated structure and built new jar at java 11
This is inconvenient for the user Changed code to initialize with the list loaded
Published UG
added inline text
… functions to stop working Changed code and tested
… not noted Shifted Duketest file along with updating gradle file for test to work
Add javadoc to all the public methods
Abstract part of load() method to parser class and cleaned up code
damithc
reviewed
Oct 12, 2021
damithc
left a comment
damithc
left a comment
Contributor
There was a problem hiding this comment.
Had a quick look (not a full review) and added some comments. Optional to fix. FYI only.
| try { | ||
| storage.save(tasks); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
Contributor
There was a problem hiding this comment.
Doesn't look like a good way to handle this exception. 🤔
| } catch (NumberFormatException e) { | ||
| updateError.setText("Please enter integer"); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
These three methods seem to be very similar. See if you can reduce duplication.
| at.split("/")[0])); | ||
| } else { | ||
| date = LocalDate.parse(at); | ||
| } |
Contributor
There was a problem hiding this comment.
There are some similar code elsewhere. Minimize code duplication.
| */ | ||
| public static ArrayList<Task> storageParse(String storageData) { | ||
| ArrayList<Task> tasks = new ArrayList<>(); | ||
| if (!storageData.equals("")) { |
Contributor
There was a problem hiding this comment.
You can use a guard clause to reduce nesting. e.g.,
if (storageData.equals("")) {
return tasks;
}
...| ArrayList<Task> tasks = new ArrayList<>(); | ||
| if (!storageData.equals("")) { | ||
| for (String i : | ||
| storageData.split("\n")) { |
Contributor
There was a problem hiding this comment.
Is this line break needed?
| public String toString() { | ||
| if (this.list.isEmpty()) { | ||
| return "There are no tasks in your list!\n"; | ||
| } else { |
Contributor
There was a problem hiding this comment.
No need to put this inside else as line 116 is a return statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.