[Rama Venkatesh] iP by ramaven · Pull Request #503 · nus-cs2103-AY2122S1/ip

ramaven · 2021-09-02T12:38:44Z

Duke

"Sometimes our stop-doing list needs to be bigger than our to-do list."
~ Patti Digh, Four-Word Self-Help: Simple Wisdom for Complex Lives

Duke frees your mind of having to remember things you need to do. It is:

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is:

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines and events
Marking item as done
Searching for items in your list

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
        public static void main(String[] args) {
            Application.launch(MainApp.class, args);
        }
 }

Wilfredwongkc

LGTM! Just some nits on coding standards and then it should be fine.

Wilfredwongkc · 2021-09-02T13:02:26Z

+                    System.out.println("   Noted. I've removed this task: ");
+                    System.out.println("  " + tasktoDel.toString());
+                }
+                else if(input.substring(0,8).equals("deadline")){


Suggested change

else if(input.substring(0,8).equals("deadline")){

else if(input.substring(0,8).equals("deadline")) {

Wilfredwongkc · 2021-09-02T13:02:44Z

+                    System.out.println("Got it. I've added this task: ");
+                    System.out.print("  " + newTask.toString());
+
+                } else if(input.substring(0,5).equals("event")){


Suggested change

} else if(input.substring(0,5).equals("event")){

} else if(input.substring(0,5).equals("event")) {

Wilfredwongkc · 2021-09-02T13:02:54Z

+                if(input.length()<4 ){
+                    throw new DukeException("Unacceptable input");
+                }
+                if(input.substring(0,4).equals("todo")){


Suggested change

if(input.substring(0,4).equals("todo")){

if(input.substring(0,4).equals("todo")) {

Wilfredwongkc · 2021-09-02T13:03:43Z

+import tasks.*;
+import exceptions.*;


Maybe can name out all the files that you are importing instead of using a wildcard?

Wilfredwongkc · 2021-09-02T13:04:10Z

+                for(int i = 0; i < taskCounter; i++){
+                    System.out.println((i+1) + "." + tasks.get(i).toString());
+                }
+            } else if (input.length() > 4 && input.substring(0,4).equals("done")){


Suggested change

} else if (input.length() > 4 && input.substring(0,4).equals("done")){

} else if (input.length() > 4 && input.substring(0,4).equals("done")) {

Wilfredwongkc · 2021-09-02T13:05:30Z

+                }
+            } else if (input.length() > 4 && input.substring(0,4).equals("done")){
+                String taskDone = input.substring(5);
+                int taskDoneIndex = Integer.parseInt(taskDone)-1;


Suggested change

int taskDoneIndex = Integer.parseInt(taskDone)-1;

int taskDoneIndex = Integer.parseInt(taskDone) - 1;

Wilfredwongkc · 2021-09-02T13:05:53Z

+                System.out.println(tasks.get(taskDoneIndex).toString());
+            }
+            else {
+                if(input.length()<4 ){


Suggested change

if(input.length()<4 ){

if (input.length() < 4) {

Wilfredwongkc · 2021-09-02T13:06:34Z

+                    taskCounter++;
+                    System.out.println("Got it. I've added this task: ");
+                    System.out.println("  " + newEvent.toString());
+                } else if(input.length()>5 && input.length()<8){


Suggested change

} else if(input.length()>5 && input.length()<8){

} else if (input.length() > 5 && input.length() < 8) {

Wilfredwongkc · 2021-09-02T13:07:02Z

+                } else if(input.length()>5 && input.length()<8){
+                    throw new DukeException("Unacceptable input");
+                }
+                else if(input.substring(0,6).equals("delete")) {


Suggested change

else if(input.substring(0,6).equals("delete")) {

else if (input.substring(0,6).equals("delete")) {

Wilfredwongkc · 2021-09-02T13:12:07Z

+        }} catch (DukeException e){
+            System.out.println("OOPS!!! You have enteted an invalid category");
+        }


I think can format the curly braces better?

aakanshanarain

Looks ok! I think you could work on the formatting of the braces as well as including whitespace in your code. Good luck!

aakanshanarain · 2021-09-05T07:21:48Z

+    }
+
+    @Override
+    public String toString(){


public String toString() {

aakanshanarain · 2021-09-05T07:22:53Z

+    @Override
+    public String toString(){
+        String typeString = type == TaskType.TODO ? "T" : type == TaskType.EVENT? "E" : "D";
+        String doneSymbol = isDone? "X" : " ";


String doneSymbol = isDone ? "X" : " ";

aakanshanarain · 2021-09-05T07:23:23Z

+    @Override
+    public String toString(){
+        String typeString = type == TaskType.TODO ? "T" : type == TaskType.EVENT? "E" : "D";
+        String doneSymbol = isDone? "X" : " ";


String doneSymbol = isDone ? "X" : " ";

Added DukeDate parse

Branch a coding standard

added javadocs

added find functionality

Add Gradle support pull req

added gradle support

checkstyle

modified gradle build file

Added GUI

No assert statements are present. Add statements are needed to declare for things that ought to be true at that point in time

Add assert statements

Find command is case sensitive A case insensitive find is more user-friendly because users cannot be expected to remember the exact case of the keywords Let's, * update the search algorithm to use case-insensitive matching

Find command: make matching case insensitive

Coding standard not fully adhered to and SLAP principle not followed in Ui class Adhering more closely to coding standards makes code more readable and better understood, and following coding principles makes it easier for other programmers to understand it. Let's * fix the order of import statements * follow SLAP principle in Ui class' init method * simplify complicated expressions in FindCommand class

Improve code quality

damithc and others added 10 commits July 29, 2021 20:30

Add Gradle support

d839859

Level-1

a5e37a0

Level-2

9f114de

Level-3

254a843

Level-4

dcbae92

Level-5

cba3a3a

Level-6

ec3c11f

modified expected output

913b02f

enum & refactoring

75ec70d

enum; refactoring

76f877c

Wilfredwongkc suggested changes Sep 2, 2021

View reviewed changes

aakanshanarain reviewed Sep 5, 2021

View reviewed changes

ramaven and others added 18 commits September 5, 2021 20:23

added save functionality

d6610f1

added save

6e00451

Added DukeDate parse

a4d5124

Merge branch 'master' into branch-Level-8

98be0ed

Merge pull request #1 from ramaven/branch-Level-8

bb01e2e

Added DukeDate parse

fixed getDate() bug

f54b7d8

refactored packages

6e50441

removed debug statements

54125a4

added Command class; OOP

c471774

adhered coding standard

b330b0d

adhered coding standard

35c0733

added javadocs

49b8c33

added find functionality

a5955e0

Merge pull request #2 from ramaven/branch-A-CodingStandard

0dd98f3

Branch a coding standard

Merge pull request #3 from ramaven/branch-A-JavaDoc

deafde9

added javadocs

Merge pull request #4 from ramaven/branch-Level-9

80d6917

added find functionality

Merge pull request #6 from ramaven/add-gradle-support

84bc195

Add Gradle support pull req

fixed file save bug

f1722c7

ramaven and others added 30 commits September 12, 2021 15:37

fixed file save bug

90738d5

added gradle support

8c536cb

Merge branch 'master' into branch-A-Gradle

1848605

Merge pull request #7 from ramaven/branch-A-Gradle

6657c54

added gradle support

checkstyle

d183176

Merge pull request #8 from ramaven/branch-A-Checkstyle

559aa07

checkstyle

modified gradle build file

6137ed5

Merge branch 'master' into branch-A-Checkstyle

99eeead

Merge pull request #9 from ramaven/branch-A-Checkstyle

0dc6f8e

modified gradle build file

Added GUI

48c8b01

Merge pull request #10 from ramaven/branch-Level-10

6f08fb4

Added GUI

Add assert statements

a6c7cec

No assert statements are present. Add statements are needed to declare for things that ought to be true at that point in time

Merge pull request #11 from ramaven/branch-A-Assertions

431ad92

Add assert statements

Find command: make matching case insensitive

b919c18

Find command is case sensitive A case insensitive find is more user-friendly because users cannot be expected to remember the exact case of the keywords Let's, * update the search algorithm to use case-insensitive matching

Merge pull request #12 from ramaven/branch-C-BetterSearch

23b81b1

Find command: make matching case insensitive

Merge pull request #13 from ramaven/branch-A-CodeQuality

85deaac

Improve code quality

Add product screenshot

375ee70

Add user guide

5db5d46

Set theme jekyll-theme-minimal

790acc6

Set theme jekyll-theme-leap-day

b5d33a9

Edit User Guide

1e5ca13

Merge branch 'master' of https://github.com/ramaven/ip

0557aa0

Update README

855c0ad

Update README.md

dc82355

Update README.md

27a3096

Update README.md

f17b05f

Add credits

a9ce5a5

Improve code quality

979f83f

Add test methods

8e8c1d7

	else if(input.substring(0,8).equals("deadline")){
	else if(input.substring(0,8).equals("deadline")) {

	} else if(input.substring(0,5).equals("event")){
	} else if(input.substring(0,5).equals("event")) {

	if(input.substring(0,4).equals("todo")){
	if(input.substring(0,4).equals("todo")) {

	} else if (input.length() > 4 && input.substring(0,4).equals("done")){
	} else if (input.length() > 4 && input.substring(0,4).equals("done")) {

	int taskDoneIndex = Integer.parseInt(taskDone)-1;
	int taskDoneIndex = Integer.parseInt(taskDone) - 1;

	} else if(input.length()>5 && input.length()<8){
	} else if (input.length() > 5 && input.length() < 8) {

	else if(input.substring(0,6).equals("delete")) {
	else if (input.substring(0,6).equals("delete")) {

Uh oh!

Conversation

ramaven commented Sep 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Duke

Uh oh!

Wilfredwongkc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aakanshanarain left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ramaven commented Sep 2, 2021 •

edited

Loading