[Toh Zhen Yu, Nicholas] iP by nicktohzyu · Pull Request #457 · nus-cs2103-AY2021S1/ip

nicktohzyu · 2020-08-28T17:50:19Z

No description provided.

todo/deadline/event commands and classes

had to compile in java 8 due to runtime environment on local

fix indexing bug abstract number of tasks message delete command

using java serialization needs work handling non existant directories

refactor input/output and messages into UI

not necessary for tasks to have a storage object

add private constructor remove unused store method

Empty commit: project already follows a coding standard

add find command

Add javadoc for find Refactor print_tasks to use UI

Door-oof

Overall, I find your code readable. However, there are some coding standards violations that needs to be fixed. Nevertheless, a good job.

Door-oof · 2020-08-31T02:21:17Z

+        String[] subst;
+        LocalDate date;
+        switch (command) {
+            case "list":


This is incorrect because there should not be any indentation for the case clauses.

Door-oof · 2020-08-31T02:43:46Z

+public class Deadline extends Task {
+
+    /**
+     * @param description Task description


There should be a punctuation behind every parameter description. I have noticed similar issue in other places too.

Door-oof · 2020-08-31T02:49:19Z

+    @Test
+    public void dummyTest(){
+        Task t = new Task("test1", LocalDate.parse("2001-09-11"));
+//        System.out.println(t.toString());


This is incorrect as comments should be indented relative to their position in the code.

Door-oof · 2020-08-31T02:56:47Z

@@ -1,10 +1,34 @@
+/**


Perhaps putting the class in a package?

Door-oof · 2020-08-31T03:01:19Z

@@ -0,0 +1,55 @@
+import java.io.*;


The imported classes should be listed explicitly.

Door-oof · 2020-08-31T04:00:34Z

+ */
+public class Task implements java.io.Serializable {
+    String text;
+    boolean done;


Perhaps a more intuitive variable name that will sound more like a boolean?

Door-oof · 2020-08-31T04:14:16Z

+
+    /**
+     * Entry point of the duke program. Read from storage and creates a UI class instance.
+     * Serves as intermediate between the UI and parser.


This is incorrect as there should be an empty line between the description and parameter. I have noticed similar issues in several other places too.

Door-oof · 2020-08-31T04:22:00Z

+ */
+public class Deadline extends Task {
+
+    /**


Perhaps adding a short summary of the method? This can also apply to other methods that do not have a description in other places.

thanks, not sure how I should describe the constructor or toString, do you have suggestions?

LimZeWeiDennis

All in all, the code was easy to read and understand. There was no deep nesting done, and the code was not complicated. The names of the variables made sense in accordance to the methods. However, some form of packaging can be done to make the organisation of the code cleaner!

JinHao-L

Your code is quite neat and easy to follow. There is no overly complicated code that needs abstraction. I agree with most of the changes suggested by Door-oof and suggested some minor violations that he might have missed out.

Besides packaging, I also recommend considering the usage of public vs protected access modifiers as I noticed that public is used for certain methods while protected is used for others, even though both methods should have the same accessibility level.

Overall, it's quite a good piece of work and a pleasure to read.

JinHao-L · 2020-09-01T11:29:45Z

+            case "done":
+            case "delete":


The "done" case should end with a break; statement. You might have unintentionally shifted the "done" case into the "delete" case.

Hi, this was intentional as both commands use the same logic of tokenizing the input to get the task number, then getting that task object. It is after these steps where the logic then differs. Do you have a suggestion of a better way to do this?

JinHao-L · 2020-09-01T11:32:33Z

+                break;
+            default:
+                throw new DukeException("I'm sorry, but I don't know what that means :-(");
+//                        break;


A break statement should be included for the default case too.

Hmm intellij complains about this as it's an unreachable statement. Do you know how I can configure it to ignore this error, or have a suggestion on how to implement this logic instead?

# Conflicts: # .gitignore # build.gradle

improve code quality

add assertions

damithc and others added 30 commits July 23, 2020 23:27

Add Gradle support

3b19ba1

level-1

d6b1456

add greet

49fdaf1

level2

52ff3b3

task tostring for done status

48f8a1e

mark task as done

1c9189f

Level 4

d91440c

todo/deadline/event commands and classes

automated testing

28ca00a

had to compile in java 8 due to runtime environment on local

filter invalid input

b2c3edd

Update Duke.java

17f4128

fix indexing bug abstract number of tasks message delete command

abstract out Tasks class

f74aa3c

serialization

73ecf65

data storage

9d526f1

using java serialization needs work handling non existant directories

implement LocalDate for Event and Deadline

dea5581

Merge branch 'branch-Level-8' into master

f128e30

OOP UI

d3d481d

refactor input/output and messages into UI

OOP Storage

43fd410

OOP Parser

eba4197

add message on successful load

68f0af7

fix serialization bug, rename Tasks to TaskList

92603f8

not necessary for tasks to have a storage object

fix styling

54597fe

A-JUnit

24f5318

Create MANIFEST.MF

9d2e2e4

cleanup TaskList

a7ae636

add private constructor remove unused store method

A-CodingStandard

8dfb179

Empty commit: project already follows a coding standard

Add javadocs

99b108f

Level-9

f143e67

add find command

Merge tag 'Level-9' into master

3607d1a

Merge tag 'A-CodingStandard' into master

316ab12

Update TaskList.java

42e8830

Add javadoc for find Refactor print_tasks to use UI

nicktohzyu and others added 2 commits August 26, 2020 12:50

Remove redundant code

3f2e05e

build.gradle: Update version to 8.29

a75fcee

Door-oof reviewed Aug 31, 2020

View reviewed changes

LimZeWeiDennis reviewed Sep 1, 2020

View reviewed changes

JinHao-L reviewed Sep 1, 2020

View reviewed changes

nicktohzyu added 7 commits September 2, 2020 12:49

Merge branch 'add-gradle-support'

34f572c

Update build.gradle

d24d425

Update build.gradle

6de3764

Update .gitignore

9933b7b

Update .gitignore

6a8c20a

Merge branch 'branch-Level-10' into master

0177fda

# Conflicts: # .gitignore # build.gradle

add assertions

0a4bb48

nicktohzyu force-pushed the master branch from 0a4bb48 to 0177fda Compare September 9, 2020 10:16

nicktohzyu and others added 10 commits September 9, 2020 22:36

improve code quality

02bc264

Merge pull request #2 from nicktohzyu/branch-A-CodeQuality

7671eb9

improve code quality

Merge pull request #1 from nicktohzyu/branch-A-Assertions

dc66c72

add assertions

move tasks to package

aedb323

Fix imports and remove unreachable statement

41238c8

Update .gitignore

9132476

C-sort

1467d91

implement GUI part 1 to 3

7b29628

refactor fxml

29d63f0

Update Parser.java

d7274aa

nicktohzyu force-pushed the master branch from d7274aa to 1467d91 Compare September 16, 2020 07:33

nicktohzyu added 3 commits September 16, 2020 15:35

Merge branch 'branch-Level-10' into master

98466a8

improve gui

16f9125

update readme and ui screenshot

4fd75cc

Conversation

nicktohzyu commented Aug 28, 2020

Uh oh!

Door-oof left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LimZeWeiDennis left a comment

Choose a reason for hiding this comment

Uh oh!

JinHao-L left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants