Skip to content

Commit

Permalink
git-series-push: remove get_maintainer.pl options
Browse files Browse the repository at this point in the history
These options were never really used so let's just remove that
possibility for now. It will make a future change (of only calling the
script on version 1 of the series) easier.

We can always re-add this option again but let's do it only if there's a
real need for it.

While at it, rephrased the help message to remove mentions to
get_maintainers and to state that this tool can be used in more things
than linux.

Signed-off-by: Nuno Sa <[email protected]>
  • Loading branch information
nunojsa committed Apr 27, 2023
1 parent a628460 commit c045e52
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions git-series-push/git-series-push
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
set -o pipefail

usage() {
printf "Usage $0 [options] --* [get_maintainer.pl options] -- [git-publish options]
Script to send linux patchseries via git-publish. Note that each get_maintainer.pl option is given
like '--option1 --option2'. This means that the git-publish separator '--' is mandatory for having
options for both get_maintainer.pl and git-publish.
printf "Usage $0 [options] -- [git-publish options]
Script to send patchseries via git-publish. While mainly aimed to be used
for linux development, it can be used to send patches to any project based
on mailing lists.
Options:
-c, --count Should be the number of patches that will be included in the series.
Expand Down Expand Up @@ -69,7 +69,6 @@ end_series() {

count="1"
lkml="n"
options=""
first=""
out_to=()
out_cc=()
Expand Down Expand Up @@ -103,9 +102,6 @@ while [ $# -ge 1 ]; do
shift
break;
;;
--*)
options="$options $1"
;;
*)
break
;;
Expand All @@ -115,7 +111,7 @@ while [ $# -ge 1 ]; do
done

if [[ ${no_linux} == "n" ]]; then
OPTS="--no-roles --no-rolestats --remove-duplicates --git --git-min-percent=67 $options"
OPTS="--no-roles --no-rolestats --remove-duplicates --git --git-min-percent=67"
to=$(git show -$count | scripts/get_maintainer.pl $OPTS --no-m --no-r)
cc=$(git show -$count | scripts/get_maintainer.pl $OPTS --no-l)

Expand Down

0 comments on commit c045e52

Please sign in to comment.