Skip to content

fix: Optimize Windows path compatibility#68

Open
svensxl wants to merge 1 commit intonumman-ali:mainfrom
svensxl:fix-local-windows-path
Open

fix: Optimize Windows path compatibility#68
svensxl wants to merge 1 commit intonumman-ali:mainfrom
svensxl:fix-local-windows-path

Conversation

@svensxl
Copy link

@svensxl svensxl commented Feb 4, 2026

This pull request improves the detection of local file paths in the isLocalPath utility, making it more robust and cross-platform. It expands support for Windows-specific path formats and updates the test suite to ensure all relevant cases are covered.

Enhancements to local path detection:

  • Improved the isLocalPath function in src/commands/install.ts to recognize Windows drive letter paths (e.g., C:This pull request improves the detection of local file paths in the isLocalPath` utility, making it more robust and cross-platform. It expands support for Windows-specific path formats and updates the test suite to ensure all relevant cases are covered.

Enhancements to local path detection:

or C:/), UNC paths (e.g., \server\share), Windows-style relative paths (e.g., .This pull request improves the detection of local file paths in the isLocalPath` utility, making it more robust and cross-platform. It expands support for Windows-specific path formats and updates the test suite to ensure all relevant cases are covered.

Enhancements to local path detection:

or ..This pull request improves the detection of local file paths in the isLocalPath` utility, making it more robust and cross-platform. It expands support for Windows-specific path formats and updates the test suite to ensure all relevant cases are covered.

Enhancements to local path detection:

), and bare ~ as the home directory, in addition to Unix-style paths.

Expanded test coverage:

  • Updated the test implementation in tests/commands/install.test.ts to match the new isLocalPath logic, ensuring correctness across platforms.
  • Added comprehensive test cases for Windows drive letter paths, UNC paths, Windows-style relative paths, and edge cases (e.g., invalid drive letters and bare ~).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant