fix: Windows path support across CLI commands#66
Open
abevol wants to merge 1 commit intonumman-ali:mainfrom
Open
fix: Windows path support across CLI commands#66abevol wants to merge 1 commit intonumman-ali:mainfrom
abevol wants to merge 1 commit intonumman-ali:mainfrom
Conversation
- Fix numman-ali#64: sync command now expands tilde (~) on Windows - Fix numman-ali#65: install command recognizes Windows absolute paths (C:/, C:\) - Support both forward and backward slashes for tilde paths (~/ and ~\) - Support Windows drive letters in both formats (C:/ and C:\) Changes: - Updated sync.ts to expand tilde paths before processing - Enhanced isLocalPath() to detect Windows drive letters - Updated expandPath() to handle both Unix and Windows tilde notation This makes the CLI more intuitive for Windows users, especially those using Git Bash or other Unix-like shells on Windows.
abevol
changed the title
abevol
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Windows path handling issues reported in #64 and #65, and adds support for both forward and backward slashes in path inputs.
Changes
Fixed Issues
synccommand's-oparameter now correctly expands tilde (~) to the user's home directory on Windowsinstallcommand now recognizes Windows absolute paths (C:/, `C:) tilde notation across all commandsC:/) and backslash (`C:\/^[a-zA-Z]:[/\]/expandPath()to support both Unix and Windows tilde notationTesting
Before/After
Before
After
Impact
This change makes the CLI more user-friendly for Windows users without affecting Unix/Linux/macOS behavior. All existing functionality is preserved while adding Windows-specific path format support.