Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent FactorFence key controls from firing when an input is focused #552

Merged
merged 2 commits into from
Mar 30, 2025

Conversation

gwhitney
Copy link
Collaborator

By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.


Resolves #478.

I can't get anything bad to happen with these code changes, but please beat on FactorFence as thoroughly as you can when reviewing. Thanks!

@katestange
Copy link
Member

Thanks, I banged on it and it seems to work well. Thanks for exposition in the code, it looks good.

@katestange katestange merged commit a18aa34 into numberscope:ui2 Mar 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants