-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Enhance ModFill coloration #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One question for @katestange to consider in review: All of the Featured Specimens using modfill are either monochrome or two-tone, just because of the former structure of the color options. Is it worth seeking an example where use of a more extensive palette in ModFill is interesting/helpful, and adding that to the Featured Specimens or subbing it in for an existing one? One simple version of this would be to just change the Fill color for "Woven Residues" to be |
This all looks good and everything seems to work. And yes, I like |
CI needs update, then I'll merge |
OK, all should be well now. |
* refactor: convert Sunzi to boolean param since background has opacity * refactor: consolidate ModFill coloring parameters * doc: Update Fill color and Sunzi mode documentation * chore: update GitHub CI snapshots for Fill color parameter * feat: use rainbow colors in Woven Residues * dummy: grab ci snapshots for updating * test: update WovenResidues CI snapshots
By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.
Resolves #519.
Will need CI snapshot update because parameter tab layout changed slightly.