Skip to content

feat: Enhance ModFill coloration #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 28, 2025

Conversation

gwhitney
Copy link
Collaborator

By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.


  • Consolidates ModFill color parameters into a single formula. This removes the issue about highlighting persisting when it should not.
  • Changes Sunzi mode to a boolean parameter, since the opacity can now just be encoded in the background color.
  • Updates documentation.

Resolves #519.

Will need CI snapshot update because parameter tab layout changed slightly.

@gwhitney
Copy link
Collaborator Author

One question for @katestange to consider in review: All of the Featured Specimens using modfill are either monochrome or two-tone, just because of the former structure of the color options. Is it worth seeking an example where use of a more extensive palette in ModFill is interesting/helpful, and adding that to the Featured Specimens or subbing it in for an existing one? One simple version of this would be to just change the Fill color for "Woven Residues" to be rainbow(n/2) rather than the default black, since it's just for visual effect anyway... Otherwise, I think all is well here, but of course look forward to other review feedback if any.

@katestange
Copy link
Member

This all looks good and everything seems to work. And yes, I like rainbow(n/2) if you'd like to do that before I merge.

@katestange
Copy link
Member

CI needs update, then I'll merge

@gwhitney
Copy link
Collaborator Author

OK, all should be well now.

@katestange katestange merged commit 812ecf9 into numberscope:ui2 Mar 28, 2025
2 checks passed
katestange pushed a commit to katestange/frontscope that referenced this pull request Apr 5, 2025
* refactor: convert Sunzi to boolean param since background has opacity

* refactor: consolidate ModFill coloring parameters

* doc: Update Fill color and Sunzi mode documentation

* chore: update GitHub CI snapshots for Fill color parameter

* feat: use rainbow colors in Woven Residues

* dummy: grab ci snapshots for updating

* test: update WovenResidues CI snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants