refactor: Move ShowFactors to workbench. #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I think all is well here now. |
|
Works, passes tests. |
katestange
pushed a commit
to katestange/frontscope
that referenced
this pull request
Apr 5, 2025
* test: Update snapshots for new transversal; fix a console.log * test: Update CI snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.
This is the direct analogue of #548 but for ShowFactors. In this case, I also went through the "overhaul list," but it didn't really amount to anything in the case of ShowFactors because it has no parameters. Also, this time the removal of a visualizer changed the (pseudorandom) "transversal" test enough so that I have to update the CI snapshots before this is ready to review. I will add a message when that is done.
Resolves #452.