doc: update instructions for running on Mac #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katestange
requested changes
Mar 16, 2025
|
OK, I think that covers everything you mentioned. |
|
I think you missed some comments that were "folded up" |
|
So right you are. Hopefully I have taken care of them now. |
|
Oh, somehow the change triggered lint. I will take out space and make lint happy. |
katestange
pushed a commit
to katestange/frontscope
that referenced
this pull request
Apr 5, 2025
* doc: update instructions for running on Mac * doc: fix typos from review * doc: oops more typos from review * doc: and now make lint happy * doc: and fix punctuation order * doc: remove ugly space and fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.
This PR was created entirely on a Mac, to make sure that the frontscope is looking OK on Safari. There were various installation bumps, and just a few code changes -- so this PR is mostly documentation of everything I did. Once I got it running, frontscope looked great on Safari, so fortunately nothing substantive to do there. I did not actually get Docker running on MacOS or run the e2e tests, mostly because I figured we don't have MacOS snapshots so it would be pretty meaningless anyway.
But this PR does need checking, running, and e2e tests on linux by a reviewer to make sure it didn't disrupt anything for our standard development and execution environment.