File tree 2 files changed +11
-3
lines changed
source/Nuke.Common/Execution
2 files changed +11
-3
lines changed Original file line number Diff line number Diff line change @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
6
6
7
7
## [ vNext]
8
8
9
+ ## [ 0.17.6] / 2019-03-04
10
+ - Fixed ` RequirementService ` to check for ` ParameterAttribute ` when injecting values interactively
11
+
9
12
## [ 0.17.5] / 2019-03-03
10
13
- Fixed ` GlobDirectories ` and ` GlobFiles ` to not collect items lazily
11
14
@@ -324,7 +327,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
324
327
- Added CLT tasks for Git
325
328
- Fixed background color in console output
326
329
327
- [ vNext ] : https://github.com/nuke-build/common/compare/0.17.5...HEAD
330
+ [ vNext ] : https://github.com/nuke-build/common/compare/0.17.6...HEAD
331
+ [ 0.17.6 ] : https://github.com/nuke-build/common/compare/0.17.5...0.17.6
328
332
[ 0.17.5 ] : https://github.com/nuke-build/common/compare/0.17.4...0.17.5
329
333
[ 0.17.4 ] : https://github.com/nuke-build/common/compare/0.17.3...0.17.4
330
334
[ 0.17.3 ] : https://github.com/nuke-build/common/compare/0.17.2...0.17.3
Original file line number Diff line number Diff line change @@ -22,7 +22,7 @@ public static void ValidateRequirements(NukeBuild build)
22
22
{
23
23
if ( requirement is Expression < Func < bool > > boolExpression )
24
24
ControlFlow . Assert ( boolExpression . Compile ( ) . Invoke ( ) , $ "Target '{ target . Name } ' requires '{ requirement . Body } '.") ;
25
- else if ( IsMemberNull ( requirement . GetMemberInfo ( ) , build ) )
25
+ else if ( IsMemberNull ( requirement . GetMemberInfo ( ) , build , target ) )
26
26
ControlFlow . Fail ( $ "Target '{ target . Name } ' requires member '{ requirement . GetMemberInfo ( ) . Name } ' to be not null.") ;
27
27
}
28
28
@@ -34,8 +34,12 @@ public static void ValidateRequirements(NukeBuild build)
34
34
}
35
35
}
36
36
37
- private static bool IsMemberNull ( MemberInfo member , NukeBuild build )
37
+ private static bool IsMemberNull ( MemberInfo member , NukeBuild build , ExecutableTarget target = null )
38
38
{
39
+ var from = target != null ? $ "from target '{ target . Name } ' " : string . Empty ;
40
+ ControlFlow . Assert ( member . HasCustomAttribute < ParameterAttribute > ( ) ,
41
+ $ "Member '{ member . Name } ' is required { from } but not marked with a { nameof ( ParameterAttribute ) } .") ;
42
+
39
43
if ( NukeBuild . Host == HostType . Console )
40
44
InjectValueInteractive ( build , member ) ;
41
45
You can’t perform that action at this time.
0 commit comments