Merge branch 'hotfix/0.17.5'

Author: matkoch

CHANGELOG.md

@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [vNext]
 
+## [0.17.5] / 2019-03-03
+- Fixed `GlobDirectories` and `GlobFiles` to not collect items lazily
+
 ## [0.17.4] / 2019-03-02
 - Fixed bootstrapping script to not set `NUGET_XMLDOC_MODE`
 
@@ -321,7 +324,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Added CLT tasks for Git
 - Fixed background color in console output
 
-[vNext]: https://github.com/nuke-build/common/compare/0.17.4...HEAD
+[vNext]: https://github.com/nuke-build/common/compare/0.17.5...HEAD
+[0.17.5]: https://github.com/nuke-build/common/compare/0.17.4...0.17.5
 [0.17.4]: https://github.com/nuke-build/common/compare/0.17.3...0.17.4
 [0.17.3]: https://github.com/nuke-build/common/compare/0.17.2...0.17.3
 [0.17.2]: https://github.com/nuke-build/common/compare/0.17.1...0.17.2

build/Build.cs

@@ -161,7 +161,7 @@ from framework in project.GetTargetFrameworks()
         });
 
     Target Publish => _ => _
-        .DependsOn(Test, Pack)
+        .DependsOn(Clean, Test, Pack)
         .Requires(() => ApiKey, () => SlackWebhook, () => GitterAuthToken)
         .Requires(() => GitHasCleanWorkingCopy())
         .Requires(() => Configuration.Equals(Configuration.Release))

source/Nuke.Common/IO/PathConstruction.cs

@@ -72,27 +72,27 @@ public static bool IsDescendantPath(string basePath, string destinationPath)
         }
 
         [Pure]
-        public static IEnumerable<string> GlobFiles(string directory, params string[] patterns)
+        public static IReadOnlyCollection<string> GlobFiles(string directory, params string[] patterns)
         {
             var directoryInfo = new DirectoryInfo(directory);
-            return patterns.SelectMany(x => directoryInfo.GlobFiles(x)).Select(x => x.FullName);
+            return patterns.SelectMany(x => directoryInfo.GlobFiles(x)).Select(x => x.FullName).ToList();
         }
 
-        [Pure]
-        public static IEnumerable<string> GlobDirectories(string directory, params string[] patterns)
+        public static IReadOnlyCollection<AbsolutePath> GlobFiles(this AbsolutePath directory, params string[] patterns)
         {
-            var directoryInfo = new DirectoryInfo(directory);
-            return patterns.SelectMany(x => directoryInfo.GlobDirectories(x)).Select(x => x.FullName);
+            return GlobFiles((string) directory, patterns).Select(x => (AbsolutePath) x).ToList();
         }
-        
-        public static IEnumerable<AbsolutePath> GlobDirectories(this AbsolutePath directory, params string[] patterns)
+
+        [Pure]
+        public static IReadOnlyCollection<string> GlobDirectories(string directory, params string[] patterns)
         {
-            return GlobDirectories((string) directory, patterns).Select(x => (AbsolutePath) x);
+            var directoryInfo = new DirectoryInfo(directory);
+            return patterns.SelectMany(x => directoryInfo.GlobDirectories(x)).Select(x => x.FullName).ToList();
         }
-        
-        public static IEnumerable<AbsolutePath> GlobFiles(this AbsolutePath directory, params string[] patterns)
+
+        public static IReadOnlyCollection<AbsolutePath> GlobDirectories(this AbsolutePath directory, params string[] patterns)
         {
-            return GlobFiles((string) directory, patterns).Select(x => (AbsolutePath) x);
+            return GlobDirectories((string) directory, patterns).Select(x => (AbsolutePath) x).ToList();
         }
 
         private const char WinSeparator = '\\';