-
Notifications
You must be signed in to change notification settings - Fork 0
feat[fluent]: s3 builder for querying and listing files in MinIO #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… Implement static method whilst waiting for STS bugfix
…built up errors by adding a validator function
…hat uses static provider
HeloiseRigaux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is redundancy with these lines. I thought that maybe there ought to be a single method that manages the minioEndpoint request and the possible errors resulting from it.
minioEndpoint := getEnvOrConfig(cfg, "MINIO_ENDPOINT", "")
if minioEndpoint == "" {
return nil, fmt.Errorf("MINIO_ENDPOINT is required")
}
mfernd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍉 🐱 👍 🤽
Add s3 builder for querying and listing files in MinIO. Implement static method whilst waiting for STS bugfix
Note
Adds MinIO/S3 support via a new fluent builder and necessary wiring.
sdk/builders/fluent/s3_builder.go:S3BuildersupportingBucket(),Key(),Get(ctx)streaming download, andList(ctx, prefix); works with static credentials or OIDC STS (AssumeRoleWithWebIdentity), path-style addressing, and endpoint HTTPS detectionsdk/client.go: exposeClient.S3()to construct the buildersdk/utils/types.go: extendConfigurationwith MinIO fields (MinIORegion,MinIOEndpoint,MinIOAccessKey,MinIOSecretKey,MinIOUseSSL,MinIOUseOIDC)go.modand lock ingo.sumusage_examples: addrunS3Exampleand switchmainto run it; comment out other fluent/search examplesWritten by Cursor Bugbot for commit 33399b6. This will update automatically on new commits. Configure here.