Skip to content

Conversation

@harksin
Copy link
Contributor

@harksin harksin commented Dec 25, 2025

Note

Service account authentication support

  • Adds sdk/service_account.go with ServiceAccount, loaders (LoadServiceAccount, LoadServiceAccountFromJSON/Reader), validation, issuer parsing, ServiceAccountOptions, and ToConfiguration
  • Adds client constructors in sdk/client.go: NewClientFromServiceAccount, NewClientFromServiceAccountFile, NewClientFromServiceAccountJSON
  • Adds defaults/utilities in sdk/utils/helpers.go: DefaultRequestTimeout, DefaultMaxRetries, SecondsToDuration

Tests and examples

  • New sdk/service_account_test.go covering JSON loading, issuer parsing, config conversion, and client construction
  • Updates sdk/builders/fluent/query_test.go to use DataDockID and adjust expected path
  • Adds usage_examples/service_account_examples.go demonstrating file/JSON-based setup and dev TLS skipping

Tooling

  • run_tests.sh: run unit tests across all ./sdk/... packages

Written by Cursor Bugbot for commit dca2408. This will update automatically on new commits. Configure here.

Copy link

@martinmdj martinmdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe we could avoid mentionning keycloak and centering the sdk around keycloak. This could be relevant if we ever move away from it / support more idps.

@harksin harksin merged commit 01c7403 into main Dec 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants