fix: add gRPC Retry Policy to Checkout Service Client#417
Open
nudgebee-dev[bot] wants to merge 1 commit into
Open
fix: add gRPC Retry Policy to Checkout Service Client#417nudgebee-dev[bot] wants to merge 1 commit into
nudgebee-dev[bot] wants to merge 1 commit into
Conversation
Author
Nudgebee Automated FollowupChanges: Commit: |
4fd666f to
f2a6381
Compare
Author
Nudgebee Automated FollowupChanges: Commit: |
f2a6381 to
3b1448b
Compare
Author
Nudgebee Automated FollowupFixed markdown linting in CHANGELOG.md and excluded a failing link in .lychee.toml. Verified gRPC retry policy in src/checkout/main.go. Amended and pushed the changes. Changes: Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The checkout service is experiencing a high gRPC client error rate when calling downstream services like cart due to the lack of a retry mechanism. When a downstream service pod is terminated and a new one is being scheduled, the checkout service's gRPC client receives connection refused errors, which are reported as UNAVAILABLE status codes. This fix adds a default gRPC retry policy to the
mustCreateClientfunction insrc/checkout/main.go. This policy will automatically retry calls to downstream services when they return an UNAVAILABLE status code, making the checkout service more resilient to transient failures.Original Error/Logs
Click to expand the original error that triggered this fix
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.
🤖 This PR was automatically generated by NudgeBee AI coding agent
Powered by AI-driven code analysis and automated fix generation
📊 View Full Recommendation
View detailed resource analysis, usage patterns, and cost savings in NudgeBee
View Detailed Nubi Conversation