SxF PoC Simple approach #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this PoC, we don't need the encryptor address to be added to GlobalAllowList contract.
Muhammad-Altabba
approved these changes
Nov 10, 2025
Muhammad-Altabba
left a comment
Muhammad-Altabba
left a comment
There was a problem hiding this comment.
LGTM!
I am not sure from the angle of UI demonstrative purposes and its adaptability to possible future changes. But it looks good to me from the coding perspective as it is a PoC and it is expected to be oversimplified in some sense.
cygnusv
approved these changes
Nov 21, 2025
Member
cygnusv
left a comment
cygnusv
left a comment
There was a problem hiding this comment.
This PR is great and simple, thanks @manumonti for the great work! For the moment, we'll keep #2 so @Muhammad-Altabba can keep working on next steps, but I still want to keep this in mind as reference.
Member
Author
|
Fair enough! I created a new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a secondary key pair (whatever the algorithm is as long as it is supported by JWT common libraries). And sign with the passkey the public address of the secondary key pair. And use the secondary key pair to sign the JWT.
The new readme explains well how it works: https://github.com/nucypher/passkeys-jwt-poc/blob/1ba65093ee33a3705b956b217c8753077e830370/README.md
Related issue: https://github.com/nucypher/sprints/issues/273