Patch d member after adding to class - #622
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 66.07% 66.06% -0.01%
==========================================
Files 270 270
Lines 26584 26584
Branches 3901 3901
==========================================
- Hits 17565 17564 -1
Misses 7975 7975
- Partials 1044 1045 +1 🚀 New features to boost your workflow:
|
Member
|
Would you mind elaborating on what is specific to enaml-web workflow and the kind of optimization you implemented ? |
Contributor
Author
|
Thanks! There are a lot more child nodes getting added/removed than in a typical Qt application. The optimization is just a memory/speed tradeoff that switches the observer pool to use hashmaps instead of vectors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on a port of atom more optimized for enaml-web. Due to how observation works in my port it requires that members be attached to a class before observers can be added. This is only change to enaml needed for my port to work. This makes it consistent with the other use of patch_d_member in DeclarativeMeta.