multi_model_analysis command#215
Draft
tylerbarna wants to merge 1 commit into
Draft
Conversation
No actual functional code as of yet, but the scaffolding for a multi_model_analysis function has been created. There's a bunch of comments in the new file regarding implementation.
bfhealy
reviewed
Sep 5, 2023
Collaborator
bfhealy
left a comment
There was a problem hiding this comment.
@tylerbarna This framework looks on the right track to facilitate multi-model analyses. Perhaps a good next step is to adapt your settings.json file in nmma-rapid to a config file in YAML format, as mentioned in today's meeting? Then YAML-parsing code could be added here to read all arguments.
It might be additionally helpful to add a script to generate a YAML file automatically. It could call analysis.py get_parser to get its arguments/defaults, ensuring that your YAML file has the latest inputs. After that, you could modify the YAML manually as desired before running multi_model_analysis.py.
This was referenced Sep 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a command line function that will allow for users to provide multiple models/priors so they can all be run for one lightcurve at the same time and then directly compared against one another at the time of analysis. This is distinct from the existing functionality of light_curve_analysis and providing multiple models; the existing light_curve_analysis code allows for one to use a combination of multiple models to perform one analysis on a lightcurve (eg fitting a lightcurve to a mix of Model A and Model B, effectively Model A/B). This script would perform individual analysis of the lightcurve for each provided model and then compare the analyses against one another.
No actual functional code as of yet, but the scaffolding for a multi_model_analysis function has been created. There's a bunch of comments in the new file regarding implementation.
resolves #214