Remove old Bu2019lm pickle file and updates to installation documentation#105
Draft
tylerbarna wants to merge 319 commits into
Draft
Remove old Bu2019lm pickle file and updates to installation documentation#105tylerbarna wants to merge 319 commits into
tylerbarna wants to merge 319 commits into
Conversation
…sravan/main adding too lims
…sravan/main fixing mag lim issues
…rma049/file Add notes about cython to installation file.
…rma049/docfix This PR uses Bu2019lm as the example.
…main short and long grb priors
…orkflow-updates This PR attempts to run the workflow in python-package.yml on pull requests. It also standardizes the syntax of deploy-github-pages.yml with the other workflow files.
Removes the old Bu2019lm.pkl file in svdmodels and updates the documentation to include links to the oversized pickle files required to use the Bu2019lm model. Also added a note about creating a symbolic link between svdmodels folders and reorganized some of the referenced installation issues for clarity and changed some of bare urls to be hyperlinks.
tylerbarna
added
bug
Member
|
@Theodlz Is trying to fix downloading the files from Zenodo, so will tag him as a reviewer to update this once that happens. |
Member
|
@tylerbarna Please update this PR to reflect the new Zenodo download scheme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #91
Removes the old Bu2019lm.pkl file in svdmodels and updates the documentation to include links to the oversized pickle files required to use the Bu2019lm model. As discussed in the referenced issue, the current pickle file causes errors when attempting to use the Bu2019lm (kilonova) model.
Also added a note about creating a symbolic link between svdmodels folders, reorganized the installation guide and potential issues for clarity; changed some of bare urls to be hyperlinks.