Closure sequences #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- With Joao Luigi - Have to redefine prepare-inputs because LazyEnvs are not clojure.lang.Associative or java.util.Maps - Do not like the impl of `eval-sequence` or `applicative-sequence-fn` but they work and tests pass. Time to make a checkpoint.
Looks cleaner to me at least!
Just use a leaf. With João and Sophia We want to continue evaluating how we model the sequence node's data to minimize changes, and, minimize scope of what needs to be handled in engines bespokely.
- Fixed fns are a value node. - Fns that need to close over the environment are leaf nodes. - Maybe we figure out when branch nodes are appropriate? - ONLY needed to update impl and syntax test. Strong validation of the abstraction that all other tests pass without updates!
sovelten
reviewed
Feb 16, 2024
src/nodely/data.clj
Outdated
| :tags #{node-tag}}) | ||
| (s/defschema Sequence #::{:type (s/eq :sequence) | ||
| :input s/Keyword | ||
| :process-node (s/recursive #'Node) |
sovelten
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows closing over any named node in the mapped fn for sequence type nodes.
ifn?value at the:nodely.data/fnkey to being a node embedded at the:nodely.data/process-nodekey of the sequence node.