We have a tool to run a body only once, use it #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopluigi
approved these changes
Dec 5, 2023
sovelten
approved these changes
Dec 5, 2023
`dosync` does not create an exclusion context on executing its body, so it's possible for two threads to enter the `dosync` and try to run `eval-fn` independently. Only one of them will win and get into `ref-map`, but there's still two outbound requests. This is bad. Delay actually promises exactly once execution and deferred execution, which are the two things we want. Makes sure that locks are localized on individual bodies and we don't e.g. lock on the entire map.
aredington
force-pushed
the
dont-run-leafs-twice
branch
from
d1df2be to
40f9256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dosyncdoes not create an exclusion context on executing its body, so it's possible for two threads to enter thedosyncand try to runeval-fnindependently. Only one of them will win and get intoref-map, but there's still two outbound requests. This is bad.Delay actually promises exactly once execution and deferred execution, which are the two things we want. Makes sure that locks are localized on individual bodies and we don't e.g. lock on the entire map.
This is aimed as resolving @joaopluigi 's reported problem of requests firing multiple times.