Add lazy io operations #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpalmeiro
reviewed
Jan 16, 2026
Collaborator
bpalmeiro
left a comment
bpalmeiro
left a comment
There was a problem hiding this comment.
Good in general, nice work. It's a bit lacking in the text suite. You have 5 condition cases (if I counted right), and none are tested. For the sake of the pressing time situation I could let that fly and come back later to pay all that technical debt
Comment on lines
+164
to
+169
| fixed_size (Union[Bool, Tuple[Bool, int, int]]) | ||
| : Method that's either enable or disabled. | ||
| False (disabled) -> Iteratively increases size of dataframe at runtime | ||
| True (enabled) -> Requires Tuple containing | ||
| (True, number of events, index to write to) | ||
| This method is best seen in action in `process_bin_WD1()`. |
Collaborator
There was a problem hiding this comment.
Why use it like that instead of having an explicit flag and an optional parameter?
| chunks = True) | ||
| dset[0] = data | ||
| else: | ||
| index = fixed_size[2] |
Collaborator
There was a problem hiding this comment.
going back to my previous comment, it would make this more obvious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an offshoot of
include-WD1-processing, and provides the lazyreader()andwriter()functions for memory efficient manipulation of data.Lies on top of #39, so will need to be merged in that order.