-
Notifications
You must be signed in to change notification settings - Fork 5
Develop WD2 decoding #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Major additions that are still required:
|
|
I will also add some tools for reading the files quickly based on the chunking. Should these perhaps go in a differing section (analysis, core, etc)? @bpalmeiro |
|
I've added executable functionality, but now need to modify the tests to allow for this. The executable functionality also now includes the config file setup for MULE, which uses Marking it as ready for review, but needs more tests that I'll be writing over time. We can now also address issue #9 as config files are now part of MULE! 🥳 |
This commit allows for WD2 decoding to be exectured straight from the MULE binary, as well as the default config and config-reading setup. A default config is provided.
76c5b3b to
6275472
Compare
|
pytest coverage at the moment: I'm not aiming for 100%, but I believe a single test will help in increasing coverage; a test that the processing pack creates a file that matches what we expect, from start to finish. |
|
The new test explicitly attempts use the
and tests them explicitly. The new coverage is: Of The other areas can and will be tested. |
|
Only sections no longer tests are WD1 related, or a specific line (#324 of |
|
There is a bug when running the decoder for singular channels that seems to select the channel number as the number of samples, causing the output for samples to be zero, and then refusing to write an empty table to the h5 file. Why this occurs I haven't fully checked, but the tests should catch this when creating the singular channel file via decoding. Will figure this out and patch. EDIT: This is an issue actually with Wavedump 2. If you select 'multiple channels per file' but only include one channel, the number of samples appears to be zero. Ensure when only reading out from one channel that you do not say 'many channels per file'! |
|
Quite a significant bug has been found! Mathias and I were working and encountered a Channels was set to some number 10^10, which meant when trying to execute The solution to this is being implemented now. |
8f0f29a to
6cb3177
Compare
bpalmeiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a """"light"""" review, so probably missing things, but here you have my first round of comments
| assert evt_info.equals(check_evt_info) | ||
|
|
||
|
|
||
| def test_ensure_new_path_created(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing the overwriting and the successful iteration tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by successful iteration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case you don't want to overwrite, and it loops and finds an available name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TD
bpalmeiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm more or less satisfied with the addressing, although tonnes of things left to the future poor TD payer.
Good job!

This PR introduces the functionality of processing into MULE, with multichannel decoding from WaveDump 2
.binfiles now being possible.The data is stored in h5 files with a storage path and name provided by the user. I'm using this PR as a draft to develop the general structure of a pack such that the following ones will be easier to implement.