Implement SCOPE digitiser compatibility #20
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwaiton
changed the title
jwaiton
force-pushed
the
implement-scope-format
branch
from
95299ec to
03e3291
Compare
Member
Author
|
Only addition I need to make is altering the |
jwaiton
force-pushed
the
implement-scope-format
branch
from
6b1d06f to
b864117
Compare
Member
Author
|
Digitisers with Dig1 & SCOPE firmware now work! I believe the code can be refactored as its currently a bit messy to look at, but thats for another time (TD). Next is to test out Dig2 SCOPE compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #6, that until now all testing has been done on a Dig1 DPP-DSD digitiser, and as such no care has been given to the Dig1 SCOPE firmware.
In this PR, the formatting allowing for SCOPE firmware has been tentatively implemented, and will remain as a draft PR until testing can be undertaken.
The way in which data is extracted from the digitiser has also been generalised, although I believe there will be a nicer way of writing the code.