Fix RRD integer overflow by capping large values instead of zeroing them #9636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the recurring RRD export errors where VLAN score values exceed integer limits, causing "Number out of integers range" errors and complete data loss.
Problem
The
number_to_rrd_string()
function inrrd.lua
was encountering VLAN score values around1.8446744069429e+19
(close to 2^64), which exceed Lua'smath.maxinteger
range. When this happened, the function would:Solution
Instead of zeroing out overflowing values, the fix implements intelligent capping:
math.maxinteger/2
(safe large value within integer range)Example
Benefits
Fixes #9499.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.