compiler: set SourceURL in NEF file #4042
Open
+19
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turalchik
force-pushed
the
add-sourceurl-to-nef
branch
from
79d446d to
3d351a9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4042 +/- ##
==========================================
- Coverage 72.65% 72.57% -0.08%
==========================================
Files 364 364
Lines 56737 56737
==========================================
- Hits 41222 41179 -43
- Misses 13785 13826 +41
- Partials 1730 1732 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Oct 20, 2025
AnnaShaleva
reviewed
Oct 22, 2025
pkg/neotest/compile_test.go
Outdated
| require.NotEqual(t, contract1, contract2) | ||
| } | ||
|
|
||
| func TestAddSourceURLToNEFI(t *testing.T) { |
There was a problem hiding this comment.
s/TestAddSourceURLToNEFI/TestAddSourceURLToNEF
| require.NoError(t, err) | ||
|
|
||
| o := &compiler.Options{} | ||
| o.SourceURL = conf.SourceURL |
There was a problem hiding this comment.
Instead of moving this line...
Comment on lines
+71
to
+72
| ne, di, err := compiler.CompileWithOptions(srcPath, nil, o) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Just move this part ahead of m, err := compiler.CreateManifest(di, o).
There was a problem hiding this comment.
This part is already ahead.
Close #3543. Signed-off-by: Tural Devrishev <[email protected]>
Turalchik
force-pushed
the
add-sourceurl-to-nef
branch
from
3d351a9 to
6c50f45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3543.