smartcontract: add support NEP-25 #4036
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4036 +/- ##
==========================================
+ Coverage 72.48% 72.76% +0.28%
==========================================
Files 364 365 +1
Lines 56750 57147 +397
==========================================
+ Hits 41135 41583 +448
+ Misses 13880 13821 -59
- Partials 1735 1743 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
- semantic checks
- stack item serialization
See neo-project/neo#4043 also
| Overloads map[string]string `yaml:"overloads,omitempty"` | ||
| NamedTypes map[string]binding.ExtendedType `yaml:"namedtypes,omitempty"` | ||
| Overloads map[string]string `yaml:"overloads,omitempty"` | ||
| NamedTypes map[string]manifest.ExtendedType `yaml:"namedtypes,omitempty"` |
There was a problem hiding this comment.
Likely it's no longer needed here, manifest has it all.
There was a problem hiding this comment.
Do I need to write an UnmarshalYAML method for ProjectConfig or mark the NamedTypes field as deprecated?
There was a problem hiding this comment.
Just drop them and then let's see how it goes.
|
|
||
| import ( | ||
| "encoding/json" | ||
| "gopkg.in/yaml.v3" |
There was a problem hiding this comment.
Likely we no longer need yaml here.
Turalchik
force-pushed
the
support-nep-25
branch
2 times, most recently
from
1bf2759 to
0457d1a
Compare
Close #3995. Signed-off-by: Tural Devrishev <[email protected]>
Turalchik
force-pushed
the
support-nep-25
branch
from
0457d1a to
a8966da
Compare
2 participants
Close #3995.