-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log error on commit construction #142
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 58.25% 57.86% -0.40%
==========================================
Files 33 33
Lines 2271 2283 +12
==========================================
- Hits 1323 1321 -2
- Misses 863 873 +10
- Partials 85 89 +4 ☔ View full report in Codecov by Sentry. |
@roman-khimov what do you think? It's related to https://github.com/bane-labs/go-ethereum/pull/396#discussion_r1925532346. Right now the node creates an empty PreCommit and relays. It causes PreCommit verification errors on other nodes. We may avoid that by considering PreCommit/Commit creation error as critical for the node's functioning. |
Ideally, log (as an error) and do not send anything. Yeah, BFT is cool, but we don't want to send payloads that are broken by definition. |
eab43cf
to
40b1257
Compare
Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
40b1257
to
fe0edd5
Compare
It's an open question what should we do when the node failed to sign the block.