Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error on commit construction #142

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

AnnaShaleva
Copy link
Member

It's an open question what should we do when the node failed to sign the block.

@AnnaShaleva AnnaShaleva added this to the v0.3.2 milestone Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.

Project coverage is 57.86%. Comparing base (026852c) to head (fe0edd5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
send.go 27.27% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   58.25%   57.86%   -0.40%     
==========================================
  Files          33       33              
  Lines        2271     2283      +12     
==========================================
- Hits         1323     1321       -2     
- Misses        863      873      +10     
- Partials       85       89       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roman-khimov
roman-khimov previously approved these changes Jan 22, 2025
@AnnaShaleva
Copy link
Member Author

AnnaShaleva commented Jan 22, 2025

what should we do when the node failed to sign the block.

@roman-khimov what do you think? It's related to https://github.com/bane-labs/go-ethereum/pull/396#discussion_r1925532346.

Right now the node creates an empty PreCommit and relays. It causes PreCommit verification errors on other nodes. We may avoid that by considering PreCommit/Commit creation error as critical for the node's functioning.

@roman-khimov
Copy link
Member

Ideally, log (as an error) and do not send anything. Yeah, BFT is cool, but we don't want to send payloads that are broken by definition.

@AnnaShaleva AnnaShaleva force-pushed the verbose-signature-err branch 2 times, most recently from eab43cf to 40b1257 Compare January 22, 2025 16:02
@roman-khimov roman-khimov merged commit 28f5db9 into master Jan 24, 2025
10 of 12 checks passed
@roman-khimov roman-khimov deleted the verbose-signature-err branch January 24, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants