Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use melt_onset QA flag mask for south #173

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

sc0tts
Copy link
Contributor

@sc0tts sc0tts commented Nov 6, 2024

This PR fixes the inclusion of a "melt_onset" bitmask in the southern hemisphere monthly files.

@sc0tts sc0tts requested a review from trey-stafford November 6, 2024 19:53
Copy link
Contributor

@trey-stafford trey-stafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for getting this done! I have one suggestion I think we should apply, and one other idea to avoid hard-coding the max QA bitmask value. Otherwise looks good!

@trey-stafford trey-stafford merged commit 232a9f8 into main Nov 7, 2024
1 check passed
@trey-stafford trey-stafford deleted the fix_sh_monthly_ncattrs branch November 7, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants