Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stringify error in executeAction #1397

Open
wants to merge 1 commit into
base: release52
Choose a base branch
from

Conversation

ianshade
Copy link
Contributor

@ianshade ianshade commented Mar 6, 2025

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Bug fix (just affecting logs)

Current Behavior

When an error occurs in executeAction, the following would be logged: {"message":"executeFunction error: function toString() { [native code] }","level":"error"}, which is not very helpful

New Behavior

The error will be properly stringified as in other places in the code

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Just logs of the Playout Gateway in case executeAction throws

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@ianshade ianshade requested a review from a team as a code owner March 6, 2025 08:03
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.25%. Comparing base (7c45ad8) to head (b2d584e).
Report is 1 commits behind head on release52.

Additional details and impacted files
@@             Coverage Diff             @@
##           release52    #1397    +/-   ##
===========================================
  Coverage      56.24%   56.25%            
===========================================
  Files            408      408            
  Lines          73125    73125            
  Branches        4615     4625    +10     
===========================================
+ Hits           41132    41133     +1     
- Misses         31739    31901   +162     
+ Partials         254       91   -163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstarpl jstarpl added 🐛🔨 bugfix This is a fix for an issue Contribution External contribution Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛🔨 bugfix This is a fix for an issue Contribution from TV 2 Norge Contributions sponsored by TV 2 Norge (tv2.no) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants