fix: prevent queued Part from hijacking infinite Pieces from the following Part(s)

[ianshade]

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Bug fix

Current Behavior

Pieces that should start at the beginning of the Part following the dynamically inserted one, will start in the dynamically inserted Part instead. See: #1392
The problem is in the rank of the inserted part, initially set to a placeholder 99999, which tricks the logic finding infinites to continue into believing that the inserted part is the very last part of the segment.

New Behavior

In order to fix the bug, the operations are reordered: first the new rank of the part is calculated, then the infinites to continue are gathered.

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

This PR affects the Sofie Core playout logic around adlibbing, specifically queueing adlib parts.

Time Frame

We consider the bug to be severe, because it leads to unexpected results on the PGM output when some future infinites are hijacked, so it would be great to merge this fix into release52

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.22%. Comparing base (33514b1) to head (f222545).
Report is 64 commits behind head on release52.

Files with missing lines	Patch %	Lines
packages/job-worker/src/playout/adlibUtils.ts	91.66%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release52    #1396      +/-   ##
=============================================
- Coverage      56.38%   56.22%   -0.17%     
=============================================
  Files            406      408       +2     
  Lines          72655    73111     +456     
  Branches        4602     4187     -415     
=============================================
+ Hits           40967    41106     +139     
- Misses         31469    31879     +410     
+ Partials         219      126      -93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.