[DNM] subsys: storage: flash_map: Preserve firmware loader from himself #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The firmware loader shall not be allowed to modify its own partition. It was caught that it could erase itself. This patch mitigates the issue by removal of the slot1_partition mapping (it belongs to the firmware loader). MCUmgr couldn't erase the partition as it is not mapped anymore. ref.: NCSDK-36684 Signed-off-by: Andrzej Puzdrowski <[email protected]>
github-actions
bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
michalek-no
approved these changes
Dec 5, 2025
de-nordic
approved these changes
Dec 7, 2025
Contributor
|
@nvlsianpu Please rebase on latest main to get the DFU test updates. |
kszromek-nordic
approved these changes
Dec 8, 2025
nvlsianpu
changed the title
Contributor
|
Replaced by #556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firmware loader shall not be allowed to modify its own partition. It was caught that it could erase itself.
This patch mitigates the issue by removal of the slot1_partition mapping (it belongs to the firmware loader). MCUmgr couldn't erase the partition as it is not mapped anymore.
ref.: NCSDK-36684