Skip to content

Conversation

@bjorn-tore-taraldsen
Copy link
Contributor

No description provided.

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Nov 26, 2025
@github-actions
Copy link

You can find the documentation preview for this PR here.

@bjorn-tore-taraldsen bjorn-tore-taraldsen force-pushed the refactor_sample_doc branch 8 times, most recently from 9444d56 to 4b029b6 Compare November 27, 2025 08:02
@anhmolt

This comment was marked as outdated.

################################

This section is a general description of how you can explore and try out the samples provided with the nRF Connect SDK.
It describes how you can create a copy of your sample, configure it, build and program the samples to test it running on a Nordic DK’s.
Copy link
Contributor

@lemrey lemrey Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the user really supposed/expected to create a sample? Samples are something to run as-is to test and experiment with a some functionality. When the user wants to create their own application they can use a sample as a starting point I suppose, but this procedure is different from just running one of the samples directly-- and they are not creating a sample but an application.

@bjorn-tore-taraldsen bjorn-tore-taraldsen force-pushed the refactor_sample_doc branch 4 times, most recently from 060ae18 to 372adab Compare December 5, 2025 14:13
anhmolt

This comment was marked as resolved.

@b-gent b-gent force-pushed the refactor_sample_doc branch 4 times, most recently from 7b880ca to 98828a6 Compare December 9, 2025 23:22
@b-gent b-gent marked this pull request as ready for review December 9, 2025 23:35
@b-gent b-gent requested review from a team as code owners December 9, 2025 23:35
@b-gent b-gent force-pushed the refactor_sample_doc branch from 98828a6 to 516f375 Compare December 10, 2025 10:34
@NordicBuilder NordicBuilder requested review from a team and rghaddab December 10, 2025 10:34
@b-gent b-gent force-pushed the refactor_sample_doc branch from 516f375 to 58bb0c5 Compare December 10, 2025 10:40
@b-gent b-gent added this to the v1.0.0 milestone Dec 10, 2025

You will need the following information:

* The |NCS| version and toolchain version that the current |BMshort| release is based on: |ncs_release|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For release PR, ncs_release must be updated.


.. note::
This will also be the case for the Peripheral samples where we do not need a SoftDevice.
Reason for this is the selected board target and that we have decided to not have any board targets without SoftDevice included.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Reason for this is the selected board target and that we have decided to not have any board targets without SoftDevice included.
Reason for this is the selected board target and that we have chosen to not have any board targets without SoftDevice included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote this one to:

This is because the SDK does not include board targets without the SoftDevice, in order to reduce complexity.

@eivindj-nordic @bjorn-tore-taraldsen let me know if it works


.. include:: /includes/softdevice_flash.txt

.. _ble_bms_sample_testing:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup.

Suggested change
.. _ble_bms_sample_testing:

I see this tag to sample testing is removed from lots of the other samples. Remove it here and in ble_hrs_central/README.rst, ble_mcuboot_recovery_entry/README.rst and ble_mcuboot_recovery_retention/README.rst as well? I cannot see the tags being used anywhere (Double check this).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very low priority and doesn't affect output, I will postpone this to the release PR

@b-gent b-gent force-pushed the refactor_sample_doc branch 2 times, most recently from 451d930 to 27651b4 Compare December 10, 2025 13:27
:depth: 2

The Timer sample demonstrates the use of both single-shot and periodic timers.
The Timer sample demonstrates how to configure and use the Bare Metal Timer (ref:`lib_bm_timer`) library to generate both single-shot and periodic callback events to your application code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link (lib_bm_timer) is broken.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creds to @bjorn-tore-taraldsen for that.

Restructure sample documentation, removing common
stuff from sample to separate reference section.

Signed-off-by: Bjørn Tore Taraldsen <[email protected]>
@b-gent b-gent force-pushed the refactor_sample_doc branch from 27651b4 to a72b9e4 Compare December 10, 2025 23:50
@eivindj-nordic eivindj-nordic merged commit c52b23a into nrfconnect:main Dec 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants