services: add ble_bms #280

eivindj-nordic · 2025-08-18T12:12:23Z

Add bond management service.

github-actions · 2025-08-25T11:47:44Z

You can find the documentation preview for this PR here.

eivindj-nordic · 2025-11-07T13:15:09Z

Added unit tests. Coverage is not perfect, though I have to prioritize other tasks.

include/bm/bluetooth/services/ble_bms.h

MirkoCovizzi · 2025-11-07T13:37:54Z

doc/nrf-bm/libraries/bluetooth/services/ble_bms.rst

+Events from the service are forwarded through the event handler specified during initialization.
+For a full list of events see the :c:enum:`ble_bms_evt_type` enum.
+
+


Extra newline.

MirkoCovizzi · 2025-11-07T13:38:26Z

doc/nrf-bm/libraries/bluetooth/services/ble_bms.rst

+| Header file: :file:`include/bluetooth/services/ble_bms.h`
+| Source files: :file:`subsys/bluetooth/services/ble_bms/`
+
+:ref:`Battery Service API reference <api_ble_bms>`


Suggested change

:ref:`Battery Service API reference <api_ble_bms>`

:ref:`Bond Management Service API reference <api_ble_bms>`

MirkoCovizzi · 2025-11-07T13:46:42Z

samples/bluetooth/ble_bms/Kconfig

+	default 512
+
+config BLE_BMS_PEERS_TO_DELETE_ON_DISCONNECT_MAX
+	int "Maximum nmber of peers to delete pending peer disconnect"


Suggested change

int "Maximum nmber of peers to delete pending peer disconnect"

int "Maximum number of peers to delete pending peer disconnect"

MirkoCovizzi · 2025-11-07T13:49:07Z

tests/subsys/bluetooth/services/ble_bms/src/unity_test.c

+	}
+}
+
+


Extra newline.

Thanks, comments addressed.

nordicjm · 2025-11-11T10:07:59Z

include/bm/bluetooth/services/ble_bms.h

+
+/** @brief BMS event types. */
+enum ble_bms_evt_type {
+


Suggested change

nordicjm · 2025-11-11T10:09:18Z

include/bm/bluetooth/services/ble_bms.h

+ *         authorization code is not valid.
+ */
+uint16_t ble_bms_on_qwr_evt(struct ble_bms *bms, struct ble_qwr *qwr,
+				const struct ble_qwr_evt *evt);


bad alignment

nordicjm · 2025-11-11T10:09:42Z

samples/bluetooth/ble_bms/CMakeLists.txt

+cmake_minimum_required(VERSION 3.20.0)
+
+find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
+project(ble_lbs)


nordicjm · 2025-11-11T10:10:36Z

samples/bluetooth/ble_bms/Kconfig

+	default 10
+
+module=BLE_BMS_SAMPLE
+module-dep=LOG


Suggested change

module-dep=LOG

let's not keep re-adding this thing that has never done anything

nordicjm · 2025-11-11T10:11:22Z

samples/bluetooth/ble_bms/src/main.c

+			LOG_ERR("Failed to delete peer, nrf_error %#x", err);
+		}
+	}
+


Suggested change

nordicjm · 2025-11-11T10:12:37Z

samples/bluetooth/ble_bms/src/main.c

+		goto idle;
+	}
+
+	const bool erase_bonds = bm_buttons_is_pressed(BOARD_PIN_BTN_1);


declare variables at top of scope

subsys/bluetooth/services/ble_bms/Kconfig

nordicjm · 2025-11-11T10:13:12Z

subsys/bluetooth/services/ble_bms/Kconfig

+	default "ABCD"
+
+module=BLE_BMS
+module-dep=LOG


Suggested change

module-dep=LOG

nordicjm · 2025-11-11T10:13:47Z

samples/bluetooth/ble_bms/Kconfig

+
+menu "BLE BMS sample"
+
+config QWR_MEM_BUFF_SIZE


prefix application/sample Kconfigs with APP_ so that they won't possibly conflict with future Kconfigs added to subsystems

nordicjm · 2025-11-11T10:14:58Z

samples/bluetooth/ble_bms/Kconfig

+	default 512
+
+config BLE_BMS_PEERS_TO_DELETE_ON_DISCONNECT_MAX
+	int "Maximum number of peers to delete pending peer disconnect"


not clear to me what this does

Suggested change

int "Maximum number of peers to delete pending peer disconnect"

int "Maximum number of peers to delete upon a peer disconnect"

Rewritten as suggested by @MirkoCovizzi.

MirkoCovizzi · 2025-11-28T09:59:13Z

samples/bluetooth/ble_bms/src/main.c

+		break;
+
+	case BLE_GAP_EVT_DISCONNECTED:
+		LOG_INF("Peer disconnected, reason %d",


As far as I can see, these values (BLE_HCI_STATUS_CODES) are defined as hex.

Suggested change

LOG_INF("Peer disconnected, reason %d",

LOG_INF("Peer disconnected, reason %#x",

peknis

Just wondering about the capitalization. Server or server?

peknis · 2025-11-28T10:19:07Z

doc/nrf-bm/libraries/bluetooth/services/ble_bms.rst

+Deleting the bonds
+==================
+
+The Server deletes bonding information on client's request right away when there is no active Bluetooth® Low Energy connection associated with a bond.


Do we need to capitalize the Server?

I don't think it should be capitalized. In fact, the counterpart client is not, in the same sentence.

This was capitalized in nRF5 documentation, though I agree it is not needed.

nordicjm · 2025-12-01T07:46:04Z

subsys/bluetooth/services/ble_bms/Kconfig

+	int "Softdevice event observer priority"
+	default 0
+
+config USE_AUTHORIZATION_CODE


add prefix to these, "use authorization code" has no context, e.g. BLE_BMS_USE_AUTHORIZATION_CODE, fix in whole PR

Thanks, updated.

tests/subsys/bluetooth/services/ble_bms/Kconfig

nordicjm · 2025-12-01T08:00:02Z

subsys/bluetooth/services/ble_bms/Kconfig

+	bool "Use authorization code"
+	default y
+
+config AUTHORIZATION_CODE


missed the update?

It seems so, updated now...

MechanicV1

Approving for tests !

doc/nrf-bm/libraries/bluetooth/services/ble_bms.rst

subsys/bluetooth/services/ble_bms/Kconfig

samples/bluetooth/ble_bms/README.rst

include/bm/bluetooth/services/ble_bms.h

Add bond management service. Signed-off-by: Eivind Jølsgard <[email protected]>

eivindj-nordic · 2025-12-01T17:12:26Z

doc-postponed: missing changelog entries.

eivindj-nordic · 2025-12-09T12:04:31Z

Release notes changelog added in #557.

eivindj-nordic self-assigned this Aug 18, 2025

eivindj-nordic requested review from a team as code owners August 18, 2025 12:12

eivindj-nordic added the DNM Do not merge label Aug 18, 2025

eivindj-nordic added this to the v0.9.0 milestone Aug 19, 2025

eivindj-nordic force-pushed the ble_bms branch from e20c85f to 4d718f8 Compare August 25, 2025 11:46

eivindj-nordic requested a review from a team as a code owner August 25, 2025 11:46

eivindj-nordic removed this from the v0.9.0 milestone Sep 2, 2025

eivindj-nordic force-pushed the ble_bms branch from 4d718f8 to 92c4e79 Compare September 29, 2025 13:45

github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. labels Sep 29, 2025

eivindj-nordic force-pushed the ble_bms branch from 92c4e79 to 9076412 Compare September 30, 2025 08:37

eivindj-nordic removed the DNM Do not merge label Oct 3, 2025

eivindj-nordic added this to the v1.0.0 milestone Oct 13, 2025

eivindj-nordic added the DNM Do not merge label Oct 21, 2025

eivindj-nordic force-pushed the ble_bms branch from 9076412 to 8869608 Compare October 21, 2025 12:19

eivindj-nordic force-pushed the ble_bms branch 2 times, most recently from 0dd951c to 8a689af Compare November 7, 2025 13:03

eivindj-nordic requested a review from a team as a code owner November 7, 2025 13:03

eivindj-nordic force-pushed the ble_bms branch from 8a689af to 96bc75e Compare November 7, 2025 13:14

eivindj-nordic removed the DNM Do not merge label Nov 7, 2025

eivindj-nordic force-pushed the ble_bms branch from 96bc75e to b201c25 Compare November 7, 2025 13:21

MirkoCovizzi reviewed Nov 7, 2025

View reviewed changes

eivindj-nordic force-pushed the ble_bms branch from b201c25 to 552f994 Compare November 7, 2025 13:51

nordicjm requested changes Nov 11, 2025

View reviewed changes

eivindj-nordic force-pushed the ble_bms branch from 552f994 to 7d86a9e Compare November 12, 2025 11:17

MirkoCovizzi reviewed Nov 28, 2025

View reviewed changes

peknis approved these changes Nov 28, 2025

View reviewed changes

eivindj-nordic force-pushed the ble_bms branch 2 times, most recently from 52d0aac to 78af194 Compare November 28, 2025 12:30

nordicjm reviewed Dec 1, 2025

View reviewed changes

eivindj-nordic force-pushed the ble_bms branch from 78af194 to ec67795 Compare December 1, 2025 07:53

nordicjm reviewed Dec 1, 2025

View reviewed changes

eivindj-nordic force-pushed the ble_bms branch from ec67795 to 61448a9 Compare December 1, 2025 11:38

eivindj-nordic requested a review from nordicjm December 1, 2025 12:27

MechanicV1 approved these changes Dec 1, 2025

View reviewed changes

nordicjm approved these changes Dec 1, 2025

View reviewed changes

eivindj-nordic requested a review from anhmolt December 1, 2025 13:59

anhmolt reviewed Dec 1, 2025

View reviewed changes

include/bm/bluetooth/services/ble_bms.h Outdated Show resolved Hide resolved

eivindj-nordic force-pushed the ble_bms branch 7 times, most recently from 446c21a to e693175 Compare December 1, 2025 16:54

services: add ble_bms

f184255

Add bond management service. Signed-off-by: Eivind Jølsgard <[email protected]>

eivindj-nordic force-pushed the ble_bms branch from e693175 to f184255 Compare December 1, 2025 16:55

anhmolt approved these changes Dec 1, 2025

View reviewed changes

eivindj-nordic added the doc-postponed PR requires documentation updates, tech writer review happens later. label Dec 1, 2025

eivindj-nordic merged commit 82aa365 into nrfconnect:main Dec 1, 2025
19 of 20 checks passed

eivindj-nordic removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-postponed PR requires documentation updates, tech writer review happens later. labels Dec 9, 2025

		Events from the service are forwarded through the event handler specified during initialization.
		For a full list of events see the :c:enum:`ble_bms_evt_type` enum.

	:ref:`Battery Service API reference <api_ble_bms>`
	:ref:`Bond Management Service API reference <api_ble_bms>`

	int "Maximum nmber of peers to delete pending peer disconnect"
	int "Maximum number of peers to delete pending peer disconnect"

	int "Maximum number of peers to delete pending peer disconnect"
	int "Maximum number of peers to delete upon a peer disconnect"

	LOG_INF("Peer disconnected, reason %d",
	LOG_INF("Peer disconnected, reason %#x",

services: add ble_bms #280

services: add ble_bms #280

Uh oh!

Conversation

eivindj-nordic commented Aug 18, 2025

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

eivindj-nordic commented Nov 7, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MirkoCovizzi Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peknis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MechanicV1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eivindj-nordic commented Dec 1, 2025

Uh oh!

Uh oh!

eivindj-nordic commented Dec 9, 2025

MirkoCovizzi Nov 28, 2025 •

edited

Loading