Skip to content

fix(language-server): replace unsupported ocache maxAge -1 with safe maximum #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9romise merged 1 commit into from
Aug 27, 2026
Merged

fix(language-server): replace unsupported ocache maxAge -1 with safe maximum #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/language-core/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,18 @@ export const DEPENDENCY_FILE_GLOB = `**/{${PACKAGE_JSON_BASENAME},${PNPM_WORKSPA

export const CACHE_MAX_AGE_ONE_DAY = 60 * 60 * 24

/**
* The maximum cache age (in seconds) accepted by `ocache`'s `maxAge` option.
*
* This is the largest whole number of seconds that can be expressed within a
* 32-bit signed integer (`(2 ** 31 - 1) / 1000 ≈ 596523` hours). It acts as a
* safe upper bound for caches that should effectively live forever.
*
* This was introduced to cope with a breaking change in `ocache`: the previous
* idiom of passing `-1` to disable expiration is no longer supported, so we
* pass the largest valid `maxAge` instead to keep entries from expiring.
*/
export const CACHE_MAX_AGE_MAXIMUM = Math.trunc((2 ** 31 - 1) / 1000)

export const NPMX_DEV = 'https://npmx.dev'
export const NPMX_DEV_API = `${NPMX_DEV}/api`
4 changes: 2 additions & 2 deletions packages/language-server/src/workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { Connection, LanguageServer } from '@volar/language-server'
import type { DependencyInfo, PackageManager, WorkspaceAdapter } from 'npmx-language-core/workspace'
import type { ClientFeatures, IWorkspaceState } from 'npmx-language-service/types'
import { access, realpath as fsRealpath, readFile } from 'node:fs/promises'
import { DEPENDENCY_FILE_GLOB, PACKAGE_JSON_BASENAME } from 'npmx-language-core/constants'
import { CACHE_MAX_AGE_MAXIMUM, DEPENDENCY_FILE_GLOB, PACKAGE_JSON_BASENAME } from 'npmx-language-core/constants'
import { isDependencyFile, isPackageManifest } from 'npmx-language-core/utils'
import { WorkspaceContext } from 'npmx-language-core/workspace'
import { DEFAULT_CLIENT_FEATURES } from 'npmx-language-service/types'
Expand Down Expand Up @@ -139,7 +139,7 @@ export class WorkspaceState implements IWorkspaceState {
{
name: 'workspace-context',
getKey: (folderUri) => folderUri.path,
maxAge: -1,
maxAge: CACHE_MAX_AGE_MAXIMUM,
swr: false,
staleMaxAge: 0,
},
Expand Down
Loading