fix(language-server): replace unsupported ocache maxAge -1 with safe maximum - #153
Conversation
…afe maximum `ocache` dropped support for passing `-1` to disable cache expiration. Introduce `CACHE_MAX_AGE_MAXIMUM` (largest valid 32-bit signed seconds) and use it for the workspace-context cache to keep entries from expiring.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds the exported Merge Risk: ⚪ Minimal · up to This localized change replaces the unsupported cache-expiration value with a valid maximum while preserving non-expiring workspace-context entries; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/language-core/src/constants.tsESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. packages/language-server/src/workspace.tsESLint skipped: the matched ESLint configuration already failed (missing-dependency). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Update publisher to luo2430 - Rename package to luo2430-npmx - Switch icon to luo2430.jpg - Add README note about temporary replacement status
….com/luo2430/vscode-npmx-fork/issues/153) - Update publisher to luo2430 - Rename package to luo2430-npmx - Switch icon to luo2430.jpg - Add README note about temporary replacement status
…b.com/luo2430/vscode-npmx-fork/issues/153)](https://github.com/luo2430/vscode-npmx-fork/issues/153) - Update publisher to luo2430 - Rename package to luo2430-npmx - Switch icon to luo2430.jpg - Add README note about temporary replacement status
…b.com/luo2430/vscode-npmx-fork/issues/153)](https://github.com/luo2430/vscode-npmx-fork/issues/153) - Update publisher to luo2430 - Rename package to luo2430-npmx - Switch icon to luo2430.jpg - Add README note about temporary replacement status
|
I couldn’t seem to find any documentation on this. Could you point me to the relevant link about this change in |
|
2 participants
ocachedropped support for passing-1to disable cache expiration. IntroduceCACHE_MAX_AGE_MAXIMUM(largest valid 32-bit signed seconds) and use it for the workspace-context cache to keep entries from expiring.