Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): explicitly declare js module type #773

Closed
wants to merge 1 commit into from

Conversation

Fdawgs
Copy link

@Fdawgs Fdawgs commented Mar 20, 2025

Node 21.1.0 added a flag to detect module types that became enabled by default in Node 22.7.0.
Declaring the type will cause Node to skip detection on startup, reducing startup time.

Declaring the package type is also considered good practice according to https://nodejs.org/api/modules.html#enabling.

@Fdawgs Fdawgs requested a review from a team as a code owner March 20, 2025 07:55
@owlstronaut
Copy link

Hello @Fdawgs, thank you very much for taking the time to contribute and for your suggestion. After reviewing the change, we’ve determined that adding "type": "commonjs" isn’t necessary for our tooling. Since Node.js already treats .js files as CommonJS by default (when no "type" field is present) and because our performance and compatibility aren’t impacted in this case, incorporating this change would only add extra complexity to our toolchain without any clear benefit.

More on the matter here: https://nodejs.org/en/blog/release/v22.7.0#module-syntax-detection-is-now-enabled-by-default

Syntax detection should have no performance impact on CommonJS modules

@Fdawgs Fdawgs deleted the patch-1 branch March 20, 2025 16:09
@Fdawgs
Copy link
Author

Fdawgs commented Mar 20, 2025

No worries, thanks for the response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants