Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Convert.ToDateTime as a supported method for translation #1297 #1298

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added Convert.ToDateTime as a supported method for translation #1297 #1298

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0a8a80
Added Convert.ToDateTime as a supported method for translation #1297
TanielianVB Mar 4, 2020
42b2843
Merge branch 'dev' of https://github.com/npgsql/efcore.pg into dev
TanielianVB Mar 20, 2020
f6170df
Merge remote-tracking branch 'upstream/dev' into dev
TanielianVB Sep 4, 2020
6baa90f
Resolved changes requested during review
TanielianVB Sep 4, 2020
dba3629
Improved Convert.ToDateTime test
TanielianVB Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/EFCore.PG/Query/ExpressionTranslators/Internal/NpgsqlConvertTranslator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public class NpgsqlConvertTranslator : IMethodCallTranslator
{
[nameof(Convert.ToBoolean)] = "bool",
[nameof(Convert.ToByte)] = "smallint",
[nameof(Convert.ToDateTime)] = "timestamp with time zone",
TanielianVB marked this conversation as resolved.
Show resolved Hide resolved
[nameof(Convert.ToDecimal)] = "numeric",
[nameof(Convert.ToDouble)] = "double precision",
[nameof(Convert.ToInt16)] = "smallint",
Expand All @@ -28,6 +29,7 @@ public class NpgsqlConvertTranslator : IMethodCallTranslator
{
typeof(bool),
typeof(byte),
typeof(DateTime),
typeof(decimal),
typeof(double),
typeof(float),
Expand Down