Adjust wording

npaisnel · Apr 12, 2023 · 939d3a3 · 939d3a3
1 parent 4c19f51
commit 939d3a3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # OpenCore Legacy Patcher changelog
 
 ## 0.6.4
+- Backend changes:
+  - Implement new analytics_handler.py module
+    - Adds support for anonymous analytics including host info (and crash reports in the future)
+    - Can be disabled via GUI or `defaults write com.dortania.opencore-legacy-patcher DisableCrashAndAnalyticsReporting -bool true`
 
 ## 0.6.3
 - Update non-Metal Binaries:

diff --git a/resources/analytics_handler.py b/resources/analytics_handler.py
@@ -29,7 +29,7 @@ class Analytics:
     def __init__(self, global_constants: constants.Constants) -> None:
         self.constants: constants.Constants = global_constants
 
-        if global_settings.GlobalEnviromentSettings().read_property("DisableAnalytics") is True:
+        if global_settings.GlobalEnviromentSettings().read_property("DisableCrashAndAnalyticsReporting") is True:
             return
 
         self._generate_base_data()

diff --git a/resources/gui/gui_main.py b/resources/gui/gui_main.py
@@ -2981,10 +2981,9 @@ def dev_settings_menu(self, event=None):
         self.set_ignore_app_updates_checkbox.SetToolTip(wx.ToolTip("This will set whether OpenCore will ignore App Updates on launch.\nEnable this option if you do not want to be prompted for App Updates"))
 
         # Set Disable Analytics
-        res = global_settings.GlobalEnviromentSettings().read_property("DisableAnalytics")
-        if res is None:
-            res = False
-        self.set_disable_analytics_checkbox = wx.CheckBox(self.frame_modal, label="Disable Analytics")
+        res = global_settings.GlobalEnviromentSettings().read_property("DisableCrashAndAnalyticsReporting")
+        res = False if res is None else res
+        self.set_disable_analytics_checkbox = wx.CheckBox(self.frame_modal, label="Disable Crash/Analytics")
         self.set_disable_analytics_checkbox.SetValue(res)
         self.set_disable_analytics_checkbox.Bind(wx.EVT_CHECKBOX, self.set_disable_analytics_click)
         self.set_disable_analytics_checkbox.SetPosition(wx.Point(
@@ -3051,7 +3050,7 @@ def set_ignore_app_updates_click(self, event):
             global_settings.GlobalEnviromentSettings().write_property("IgnoreAppUpdates", False)
 
     def set_disable_analytics_click(self, event):
-        global_settings.GlobalEnviromentSettings().write_property("DisableAnalytics", self.set_disable_analytics_checkbox.GetValue())
+        global_settings.GlobalEnviromentSettings().write_property("DisableCrashAndAnalyticsReporting", self.set_disable_analytics_checkbox.GetValue())
 
     def firewire_click(self, event=None):
         if self.firewire_boot_checkbox.GetValue():