chore: Apply some clippy lints

command/src/certificate.rs

@@ -144,7 +144,7 @@ impl serde::Serialize for Fingerprint {
 
 struct FingerprintVisitor;
 
-impl<'de> Visitor<'de> for FingerprintVisitor {
+impl Visitor<'_> for FingerprintVisitor {
     type Value = Fingerprint;
 
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {

command/src/logging/display.rs

@@ -146,7 +146,7 @@ fn display_status(status: Option<u16>, pretty: bool) -> String {
     }
 }
 
-impl<'a> fmt::Display for FullTags<'a> {
+impl fmt::Display for FullTags<'_> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match (self.concatenated, self.user_agent) {
             (None, None) => Ok(()),

command/src/proto/display.rs

@@ -155,7 +155,10 @@ impl ResponseContent {
     fn display(&self, json: bool) -> Result<(), DisplayError> {
         let content_type = match &self.content_type {
             Some(content_type) => content_type,
-            None => return Ok(println!("No content")),
+            None => {
+                println!("No content");
+                return Ok(());
+            }
         };
 
         if json {
@@ -867,7 +870,8 @@ pub fn print_certificates_with_validity(
     certs: &CertificatesWithFingerprints,
 ) -> Result<(), DisplayError> {
     if certs.certs.is_empty() {
-        return Ok(println!("No certificates match your request."));
+        println!("No certificates match your request.");
+        return Ok(());
     }
 
     let mut table = Table::new();

e2e/src/tests/tests.rs

@@ -1325,8 +1325,7 @@ fn try_max_connections() -> State {
         clients.push(client);
     }
 
-    for i in 0..20 {
-        let client = &mut clients[i];
+    for (i, client) in clients.iter_mut().enumerate().take(20) {
         if i < 15 {
             client.send();
             let request = backend.receive(i);
@@ -1374,17 +1373,15 @@ fn try_max_connections() -> State {
         backend.send(i);
         println!("request {i}: {request:?}");
     }
-    for i in 15..20 {
-        let client = &mut clients[i];
+    for (i, client) in clients.iter_mut().enumerate().take(20).skip(15) {
         client.is_connected();
         let response = client.receive();
         println!("response {i}: {response:?}");
         client.is_connected();
         // assert!(response.unwrap().starts_with(&expected_response_start));
     }
 
-    for i in 15..20 {
-        let client = &mut clients[i];
+    for client in clients.iter_mut().take(20).skip(15) {
         client.is_connected();
         let response = client.receive();
         println!("response: {response:?}");

lib/src/http.rs

@@ -1153,7 +1153,7 @@ mod tests {
             let r = client.read(&mut buffer[index..]);
             println!("http client read: {r:?}");
             match r {
-                Err(e) => assert!(false, "client request should not fail. Error: {e:?}"),
+                Err(e) => unreachable!("client request should not fail. Error: {e:?}"),
                 Ok(sz) => {
                     index += sz;
                 }
@@ -1237,7 +1237,7 @@ mod tests {
             let r = client.read(&mut buffer[index..]);
             println!("http client read: {r:?}");
             match r {
-                Err(e) => assert!(false, "client request should not fail. Error: {e:?}"),
+                Err(e) => unreachable!("client request should not fail. Error: {e:?}"),
                 Ok(sz) => {
                     index += sz;
                 }
@@ -1266,7 +1266,7 @@ mod tests {
             let r2 = client.read(&mut buffer2[index..]);
             println!("http client read: {r2:?}");
             match r2 {
-                Err(e) => assert!(false, "client request should not fail. Error: {e:?}"),
+                Err(e) => unreachable!("client request should not fail. Error: {e:?}"),
                 Ok(sz) => {
                     index += sz;
                 }