Repository navigation
Conversation
Thalamus built the Mantle URL by hand and signed with service bedrock. The OpenAI SDK derives that host and signs with bedrock-mantle. Both Bedrock entrypoints load on first use so importing Thalamus still works on openai 6.17.0. The public config shapes stay the same. fixes NV-9271
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Thalamus writes CHANGELOG.md in the release commit, from the commits since the last tag. An Unreleased block is not part of that flow.
Comment on lines
+292
to
+293
| const body = JSON.parse(String((observe?.[1] as RequestInit).body)); | ||
| expect(body.headers.Authorization).toBe("Bearer bedrock-api-key-abc123"); |
There was a problem hiding this comment.
Test accepts broken observer URLs
The new observer test passes even though it sends an invalid streamUrl. MockOpenAI has no baseURL, so the URL starts with undefined/responses/. The test only checks Authorization. Give the mock a valid baseURL and assert the full streamUrl so this test catches broken observer URLs.
Prompt To Fix With AI
This is a comment left during a code review.
Path: __tests__/openai/openai.bedrock.test.ts
Line: 292-293
Comment:
**Test accepts broken observer URLs**
The new observer test passes even though it sends an invalid `streamUrl`. `MockOpenAI` has no `baseURL`, so the URL starts with `undefined/responses/`. The test only checks `Authorization`. Give the mock a valid `baseURL` and assert the full `streamUrl` so this test catches broken observer URLs.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.The provider file was already long. Client construction now lives in openai-client.ts. Session mode reads auth.kind, and setup errors that are not missing modules stay SDK errors.
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Thalamus signed Amazon Bedrock requests itself, with service
bedrockand a hand-built Mantle URL. The OpenAI SDK now owns that endpoint and signs Mantle requests withbedrock-mantle. Callers keep the same Bedrock config fields.What changed
openai/providers/bedrockandopenai/providers/bedrock/aws.Scope
Tradeoffs
baseURL: nullis passed so anAWS_BEDROCK_BASE_URLon the host cannot replace the SDK's Mantle URL.Blast radius
Anyone on Bedrock moves from
/v1to the SDK's/openai/v1host. SigV4 callers install@aws-sdk/credential-provider-node,@smithy/hash-node, and@smithy/signature-v4instead of@aws-crypto/sha256-js. Theopenaipeer floor is>=6.45.0. Novu does not construct this provider.Verification
pnpm testpassed 255 tests.pnpm typecheckpassed.https://bedrock-mantle.us-east-1.api.aws/openai/v1/responsesand signing SigV4 with servicebedrock-mantle.

Confidence Score: 5/5
The latest extraction appears safe to merge; the existing observer test gap is non-blocking.Fix with agent prompt
Summary
Moves Bedrock requests to the OpenAI SDK providers while keeping the public config fields unchanged.
Reviews (2) · Last reviewed commit: "refactor(openai): move Bedrock client se..." · Reviewed by Greptile