-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): adjust layout and improve scrolling on test trigger page #7532
Open
BiswaViraj
wants to merge
2
commits into
next
Choose a base branch
from
nv-5107-trigger-limit-text-area-input-field-2
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
approved these changes
Jan 17, 2025
@@ -143,23 +145,23 @@ export const TestWorkflowForm = ({ workflow }: { workflow?: WorkflowResponseDto | |||
</TabsList> | |||
{workflow?.origin === WorkflowOriginEnum.EXTERNAL && ( | |||
<TabsContent value="framework" className={codePanelClassName} variant="regular"> | |||
<SnippetEditor language="framework" value={snippetValue} /> | |||
<SnippetEditor language="framework" value={snippetValue} readOnly /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
BiswaViraj
force-pushed
the
nv-5107-trigger-limit-text-area-input-field-2
branch
from
January 17, 2025 08:00
3bc0175
to
1d01eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Screen.Recording.2025-01-16.at.8.11.50.PM.mov
Expand for optional sections
Related enterprise PR
Special notes for your reviewer