fix(worker): delay duration #7496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duration-limits-for-digest-and-delay-steps-in-code-first
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
…duration-limits-for-digest-and-delay-steps-in-code-first
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
…est-and-delay-steps-in-code-first
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
…duration-limits-for-digest-and-delay-steps-in-code-first
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
commented
Jan 15, 2025
| * If queueNextJob.execute returns undefined, we stop the workflow. | ||
| * Otherwise, we continue trying to queue the next job in the chain. | ||
| */ | ||
| private async tryQueueNextJobs(job: JobEntity): Promise<void> { |
There was a problem hiding this comment.
this was needed because not we have a possible exception on finally block which is not handled.
for the following workflow SMS => DELAY => IN-APP
the problem is the we handle the delay step (calculate the duration) while we executing the SMS job.
a better solution would be to handle the DELAY step while we execute the DELAY job.
a refactor will take a lot of time and we will need to create backward compatibility support for old jobs as well.
djabarovgeorge
commented
Jan 15, 2025
| const cronExpression = parseCronExpression(command.cron); | ||
| const firstTime = cronExpression.next().toDate(); | ||
| const secondTime = cronExpression.next().toDate(); | ||
| private isCronDeltaDeferDurationExceededTier( |
There was a problem hiding this comment.
i tried to create a simple "smart solution" however on every approach it became very complicated very fast, therefore I created a more simple solution where we validate the next 50 iterations of the crown with an exit if we pass 2 years.
djabarovgeorge
commented
Jan 15, 2025
| @@ -142,6 +166,10 @@ const isCronExpression = (cron: string) => { | |||
| }; | |||
|
|
|||
| const isRegularDeferAction = (command: TierRestrictionsValidateCommand) => { | |||
| if (command.deferDurationMs) { | |||
There was a problem hiding this comment.
a bug we had, where we did not check the deferDurationMs that the worker was passing.
…est-and-delay-steps-in-code-first
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer