-
Notifications
You must be signed in to change notification settings - Fork 50
Added revoke functionality #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KoditkarVedant
merged 6 commits into
notion-dotnet:main
from
Mr-Bally:feat/AddRevokeTokenEndpoint
Apr 19, 2025
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
744229d
Added revoke functionality
Mr-Bally a96af1a
Updates from PR review
Mr-Bally 0cc8057
Update from PR review
Mr-Bally bb62d1e
Added empty object for HttpClient
Mr-Bally c7349ed
moved class into separate file
Mr-Bally 25e675b
Merge branch 'main' into feat/AddRevokeTokenEndpoint
Mr-Bally File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
Src/Notion.Client/Api/Authentication/RevokeToken/AuthenticationClient.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
using System.Net.Http; | ||
using System.Threading; | ||
using System.Threading.Tasks; | ||
|
||
namespace Notion.Client | ||
{ | ||
public sealed partial class AuthenticationClient | ||
{ | ||
public async Task RevokeTokenAsync( | ||
RevokeTokenRequest revokeTokenRequest, | ||
CancellationToken cancellationToken = default) | ||
{ | ||
var body = (IRevokeTokenBodyParameters)revokeTokenRequest; | ||
|
||
var response = await _client.PostAsync<HttpResponseMessage>( | ||
ApiEndpoints.AuthenticationUrls.RevokeToken(), | ||
body, | ||
cancellationToken: cancellationToken | ||
); | ||
|
||
if (!response.IsSuccessStatusCode) | ||
{ | ||
throw new NotionApiException(response.StatusCode, | ||
null, | ||
"None success status code returned from revoke endpoint" | ||
); | ||
} | ||
} | ||
} | ||
} |
13 changes: 13 additions & 0 deletions
13
Src/Notion.Client/Api/Authentication/RevokeToken/Request/IRevokeTokenBodyParameters.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
using Newtonsoft.Json; | ||
|
||
namespace Notion.Client | ||
{ | ||
public interface IRevokeTokenBodyParameters | ||
{ | ||
/// <summary> | ||
/// The token to be revoked. | ||
/// </summary> | ||
[JsonProperty("token")] | ||
string Token { get; set; } | ||
} | ||
} |
7 changes: 7 additions & 0 deletions
7
Src/Notion.Client/Api/Authentication/RevokeToken/Request/RevokeTokenRequest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
namespace Notion.Client | ||
{ | ||
public class RevokeTokenRequest : IRevokeTokenBodyParameters | ||
{ | ||
public string Token { get; set; } | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.