Skip to content

Added revoke functionality #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 19, 2025
Merged

Added revoke functionality #456

merged 6 commits into from
Apr 19, 2025

Conversation

Mr-Bally
Copy link
Contributor

Description

Added functionality to revoke a token as per #454

Currently no unit tests on the existing endpoints so I didn't add any for this.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

As mentioned, no unit tests exist for this part of the codebase so it's manual testing only

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

github-actions[bot]
github-actions bot reviewed Apr 15, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for your first pull request! The team will review it shortly. We’re excited to have you contribute!

@KoditkarVedant KoditkarVedant requested a review from Copilot April 15, 2025 18:54
Copilot
Copilot AI reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

@Mr-Bally Mr-Bally requested a review from KoditkarVedant April 16, 2025 19:19
@Mr-Bally Mr-Bally requested a review from KoditkarVedant April 17, 2025 15:25
@KoditkarVedant
Copy link
Contributor

@Mr-Bally There is a CodeFactor error.

image

@Mr-Bally
Copy link
Contributor Author

Fixed CodeFactor issue

@Mr-Bally Mr-Bally requested a review from KoditkarVedant April 18, 2025 11:32
KoditkarVedant
KoditkarVedant approved these changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@KoditkarVedant KoditkarVedant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. congratulations on your first contribution. 🎉🎉

@KoditkarVedant KoditkarVedant merged commit 7ede362 into notion-dotnet:main Apr 19, 2025
7 checks passed
@KoditkarVedant KoditkarVedant linked an issue Apr 19, 2025 that may be closed by this pull request
Add support for revoke token endpoint #454
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Copilot code review Copilot Copilot left review comments

@KoditkarVedant KoditkarVedant KoditkarVedant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for revoke token endpoint
2 participants
@Mr-Bally @KoditkarVedant