Merged
Conversation
A class's valid_child_concerns are redefined to only include registered concerns. Ensure that only the registered concerns can be nested within each other Hyrax::NestedWorks loads the valid_child_concerns prior to the above configuration This removes Hyku's default work types from the list of valid child concerns
ShanaLMoore
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story
A class's valid_child_concerns are redefined to only include registered concerns.
Ensure that only the registered concerns can be nested within each other Hyrax::NestedWorks loads the valid_child_concerns prior to the above configuration This removes Hyku's default work types from the list of valid child concerns
Refs #93
Expected Behavior Before Changes
A work's show page will not load to logged in user in production environment.
Expected Behavior After Changes
Screenshots / Video
Notes