Fix banner image path issue and set HYRAX_UPLOAD_PATH correctly#850
Merged
aprilrieger merged 1 commit intomainfrom Mar 11, 2026
Merged
Fix banner image path issue and set HYRAX_UPLOAD_PATH correctly#850aprilrieger merged 1 commit intomainfrom
aprilrieger merged 1 commit intomainfrom
Conversation
a3db6e0 to
7fb4b40
Compare
7fb4b40 to
cd4f297
Compare
Open
ShanaLMoore
approved these changes
Mar 11, 2026
ShanaLMoore
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #846
Problem
Homepage banner images were not loading.
The image files exist and are served at:
However, the rendered CSS referenced a filesystem path instead of the public path:
Correct path:
Cause
The Hyrax Helm chart sets:
when:
This path is not under
public/, so files written there are not served at/uploads/.Our infrastructure mounts the uploads volume at:
Therefore, the application must write uploads there so the filesystem path and the public URL path align.
Solution
Set
HYRAX_UPLOAD_PATHin the deploy values to override the Helm chart default and match our volume mount.This ensures uploads are written to the location Rails serves at:
Testing
Manual verification:
Files Changed
ops/friends-deploy.tmpl.yamlHYRAX_UPLOAD_PATHto align with Hyku infra volume mountsops/production-deploy.tmpl.yamlHYRAX_UPLOAD_PATHto align with Hyku infra volume mounts